From e1cb5cf7b3ea8da8fe74609adb4d4a6c3d695e28 Mon Sep 17 00:00:00 2001 From: Zoltan Varga <91464454+zovarga@users.noreply.github.com> Date: Thu, 2 Apr 2026 17:22:39 +0200 Subject: [PATCH 1/4] Change MiniCollision index column declaration Fixing unbounded index issue for hyperloop --- PWGJE/Tasks/jetLundPlane.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PWGJE/Tasks/jetLundPlane.cxx b/PWGJE/Tasks/jetLundPlane.cxx index 6b8bd423622..132db9b3510 100644 --- a/PWGJE/Tasks/jetLundPlane.cxx +++ b/PWGJE/Tasks/jetLundPlane.cxx @@ -53,7 +53,7 @@ DECLARE_SOA_TABLE(MiniCollisions, "AOD", "MINICOLL", MiniCollTag); // MiniJets -> MiniCollisions -DECLARE_SOA_INDEX_COLUMN(MiniCollision, miniCollision); +DECLARE_SOA_INDEX_COLUMN_CUSTOM(MiniCollision, miniCollision, "MINICOLLS"); // Jet payload DECLARE_SOA_COLUMN(Level, level, uint8_t); // JetLevel::Det=reco(det), JetLevel::Part=truth(part) From 5acb1fefd6898cecebbaab2383d4cb5932420e51 Mon Sep 17 00:00:00 2001 From: Zoltan Varga <91464454+zovarga@users.noreply.github.com> Date: Thu, 2 Apr 2026 17:54:36 +0200 Subject: [PATCH 2/4] Refactor collision key calculations with constants to fix O2 linter issues --- PWGJE/Tasks/jetLundPlane.cxx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/PWGJE/Tasks/jetLundPlane.cxx b/PWGJE/Tasks/jetLundPlane.cxx index 132db9b3510..40bb75a9844 100644 --- a/PWGJE/Tasks/jetLundPlane.cxx +++ b/PWGJE/Tasks/jetLundPlane.cxx @@ -96,6 +96,8 @@ DECLARE_SOA_TABLE(MiniJetMatches, "AOD", "MINIMCH", namespace { constexpr float kTiny = 1e-12f; +constexpr uint64_t collisionKeyShift = 1ULL; +constexpr uint64_t partCollisionKeyTag = 1ULL; struct JetLevel { enum Type : uint8_t { @@ -583,7 +585,8 @@ struct JetLundPlaneUnfolding { fillSplittingQAHists(spl, /*isTruth*/ true, partJet.pt()); if (writeMiniAOD.value) { - const uint64_t partCollKey = (static_cast(partJet.mcCollisionId()) << 1U) | 1ULL; + const uint64_t partCollKey = + (static_cast(partJet.mcCollisionId()) << collisionKeyShift) | partCollisionKeyTag; int partMiniCollIdx = -1; auto collIt = partMiniCollByKey.find(partCollKey); if (collIt == partMiniCollByKey.end()) { @@ -650,7 +653,8 @@ struct JetLundPlaneUnfolding { fillSplittingQAHists(detSpl, /*isTruth*/ false, detJet.pt()); if (writeMiniAOD.value) { - const uint64_t detCollKey = (static_cast(detJet.collisionId()) << 1U); + const uint64_t detCollKey = + (static_cast(detJet.collisionId()) << collisionKeyShift); int detMiniCollIdx = -1; auto collIt = detMiniCollByKey.find(detCollKey); if (collIt == detMiniCollByKey.end()) { @@ -795,5 +799,5 @@ struct JetLundPlaneUnfolding { WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) { return WorkflowSpec{ - adaptAnalysisTask(cfgc, TaskName{"jet-lund-plane"})}; + adaptAnalysisTask(cfgc)}; } From 5dc155d4b13a42e8a0fcccef6c9290c2dcc7647e Mon Sep 17 00:00:00 2001 From: Zoltan Varga <91464454+zovarga@users.noreply.github.com> Date: Thu, 2 Apr 2026 17:59:14 +0200 Subject: [PATCH 3/4] Fixing O2 linter: Define minimum constituents for jet in jetLundPlane --- PWGJE/Tasks/jetLundPlane.cxx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PWGJE/Tasks/jetLundPlane.cxx b/PWGJE/Tasks/jetLundPlane.cxx index 40bb75a9844..0cd50f08b5b 100644 --- a/PWGJE/Tasks/jetLundPlane.cxx +++ b/PWGJE/Tasks/jetLundPlane.cxx @@ -98,6 +98,7 @@ namespace constexpr float kTiny = 1e-12f; constexpr uint64_t collisionKeyShift = 1ULL; constexpr uint64_t partCollisionKeyTag = 1ULL; +constexpr size_t MinConstituentsForJet = 2; struct JetLevel { enum Type : uint8_t { @@ -418,7 +419,7 @@ struct JetLundPlaneUnfolding { std::vector getPrimarySplittings(JetRowT const& jet, ConstituentTableT const&) { auto fjInputs = buildFastJetInputs(jet.template tracks_as(), trackPtMin.value); - if (fjInputs.size() < 2) { + if (fjInputs.size() < MinConstituentsForJet) { return {}; } From f6a0bc3798f7d9e0a1787cdcc9b40259b0aed682 Mon Sep 17 00:00:00 2001 From: ALICE Action Bot Date: Thu, 2 Apr 2026 15:59:56 +0000 Subject: [PATCH 4/4] Please consider the following formatting changes --- PWGJE/Tasks/jetLundPlane.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PWGJE/Tasks/jetLundPlane.cxx b/PWGJE/Tasks/jetLundPlane.cxx index 0cd50f08b5b..eaa2af5b3a6 100644 --- a/PWGJE/Tasks/jetLundPlane.cxx +++ b/PWGJE/Tasks/jetLundPlane.cxx @@ -587,7 +587,7 @@ struct JetLundPlaneUnfolding { if (writeMiniAOD.value) { const uint64_t partCollKey = - (static_cast(partJet.mcCollisionId()) << collisionKeyShift) | partCollisionKeyTag; + (static_cast(partJet.mcCollisionId()) << collisionKeyShift) | partCollisionKeyTag; int partMiniCollIdx = -1; auto collIt = partMiniCollByKey.find(partCollKey); if (collIt == partMiniCollByKey.end()) { @@ -655,7 +655,7 @@ struct JetLundPlaneUnfolding { if (writeMiniAOD.value) { const uint64_t detCollKey = - (static_cast(detJet.collisionId()) << collisionKeyShift); + (static_cast(detJet.collisionId()) << collisionKeyShift); int detMiniCollIdx = -1; auto collIt = detMiniCollByKey.find(detCollKey); if (collIt == detMiniCollByKey.end()) {