From bee416ef29ffa9e68f222485fef27cad9f9c7adc Mon Sep 17 00:00:00 2001 From: Benedikt Johannes Date: Sun, 22 Feb 2026 14:38:46 +0100 Subject: [PATCH 1/3] Follow-up for Fixing SSIM Test Method Names Signed-off-by: Benedikt Johannes --- tests/metrics/test_ssim_metric.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/metrics/test_ssim_metric.py b/tests/metrics/test_ssim_metric.py index d79107e999..f1b62f916f 100644 --- a/tests/metrics/test_ssim_metric.py +++ b/tests/metrics/test_ssim_metric.py @@ -21,7 +21,7 @@ class TestSSIMMetric(unittest.TestCase): - def test2d_gaussian(self): + def test_2d_gaussian(self): set_determinism(0) preds = torch.abs(torch.randn(2, 3, 16, 16)) target = torch.abs(torch.randn(2, 3, 16, 16)) @@ -34,7 +34,7 @@ def test2d_gaussian(self): expected_value = 0.045415 self.assertTrue(expected_value - result.item() < 0.000001) - def test2d_uniform(self): + def test_2d_uniform(self): set_determinism(0) preds = torch.abs(torch.randn(2, 3, 16, 16)) target = torch.abs(torch.randn(2, 3, 16, 16)) @@ -47,7 +47,7 @@ def test2d_uniform(self): expected_value = 0.050103 self.assertTrue(expected_value - result.item() < 0.000001) - def test3d_gaussian(self): + def test_3d_gaussian(self): set_determinism(0) preds = torch.abs(torch.randn(2, 3, 16, 16, 16)) target = torch.abs(torch.randn(2, 3, 16, 16, 16)) From 86621f9e61686e6e59e398b8b94cd55aca915e81 Mon Sep 17 00:00:00 2001 From: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Date: Tue, 31 Mar 2026 10:52:25 +0100 Subject: [PATCH 2/3] Apply suggestion from @ericspod Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> --- tests/metrics/test_ssim_metric.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/metrics/test_ssim_metric.py b/tests/metrics/test_ssim_metric.py index f1b62f916f..96cc08521c 100644 --- a/tests/metrics/test_ssim_metric.py +++ b/tests/metrics/test_ssim_metric.py @@ -32,7 +32,7 @@ def test_2d_gaussian(self): metric(preds, target) result = metric.aggregate() expected_value = 0.045415 - self.assertTrue(expected_value - result.item() < 0.000001) + self.assertTrue(abs(expected_value - result.item()) < 0.000001) def test_2d_uniform(self): set_determinism(0) From 6aef0fddf494db19f84b2c2d0eb063c718eac1b4 Mon Sep 17 00:00:00 2001 From: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Date: Tue, 31 Mar 2026 10:53:25 +0100 Subject: [PATCH 3/3] Apply suggestion from @ericspod Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> --- tests/metrics/test_ssim_metric.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/metrics/test_ssim_metric.py b/tests/metrics/test_ssim_metric.py index 96cc08521c..1659d2ce4a 100644 --- a/tests/metrics/test_ssim_metric.py +++ b/tests/metrics/test_ssim_metric.py @@ -45,7 +45,7 @@ def test_2d_uniform(self): metric(preds, target) result = metric.aggregate() expected_value = 0.050103 - self.assertTrue(expected_value - result.item() < 0.000001) + self.assertTrue(abs(expected_value - result.item()) < 0.000001) def test_3d_gaussian(self): set_determinism(0)