diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ff7c7c12339..188bdcca981 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -25,6 +25,7 @@ Fixes #0000 ### Post-release steps @@ -35,15 +36,9 @@ Fixes #0000 If it doesn't, feel free to remove this section. --> -### Measuring impact - -How do we know this change was effective? Please choose one: - -- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix -- [ ] Existing analytics will cater for this addition -- [ ] PR includes analytics changes to measure impact - ### Checklist - [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows) - [ ] I've considered possible [documentation](https://shopify.dev) changes +- [ ] I've considered analytics changes to measure impact +- [ ] The change is user-facing, so I've added a changelog entry with `pnpm changeset add` diff --git a/.github/workflows/changelog-reminder.yml b/.github/workflows/changelog-reminder.yml deleted file mode 100644 index c16ce28c167..00000000000 --- a/.github/workflows/changelog-reminder.yml +++ /dev/null @@ -1,22 +0,0 @@ -on: - pull_request: - types: [ opened, synchronize, reopened, ready_for_review ] - paths: [ 'packages/*/src/**' ] -name: Changelog Reminder -jobs: - remind: - name: "[PR] Changelog Reminder" - runs-on: ubuntu-latest - if: ${{ github.event.pull_request.head.repo.full_name == github.repository && !github.event.pull_request.draft }} - steps: - - uses: actions/checkout@v3 - - uses: mskelton/changelog-reminder-action@7039cd14fb784c0a2b37f6e7a6ade2c9148c2245 # v2 - with: - changelogRegex: \.changeset - message: | - We detected some changes at `packages/*/src` and there are no updates in the `.changeset`. - If the changes are user-facing, run `pnpm changeset add` to track your changes and include them in the next release CHANGELOG. - - > [!CAUTION] - > DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. -