From 5bd5623dcfe7043f2fdd8d845be08ad6e37e57a8 Mon Sep 17 00:00:00 2001 From: Alica228 Date: Wed, 18 Mar 2026 11:52:12 +0200 Subject: [PATCH 1/3] fix SMSG_ENCOUNTER_START / SMSG_ENCOUNTER_END --- .../Parsers/InstanceHandler.cs | 5 ++++- .../Parsers/InstanceHandler.cs | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs index d20de75553..f0db2245a0 100644 --- a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs @@ -152,7 +152,10 @@ public static void HandleMultiFloorNewFloor(Packet packet) public static void HandleEncounterstart(Packet packet) { packet.ReadInt32("DungeonEncounterID"); - packet.ReadInt32("DifficultyID"); + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_1_65818)) + packet.ReadInt16("DifficultyID"); + else + packet.ReadInt32("DifficultyID"); packet.ReadInt32("GroupSize"); var count = packet.ReadUInt32(); diff --git a/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs b/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs index d2d4433a6b..34fd30cdd4 100644 --- a/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs @@ -208,7 +208,10 @@ public static void HandleEncounterStart(Packet packet) public static void HandleEncounterStop(Packet packet) { packet.ReadInt32("EncounterID"); - packet.ReadInt32("DifficultyID"); + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_1_65818)) + packet.ReadInt16("DifficultyID"); + else + packet.ReadInt32("DifficultyID"); packet.ReadInt32("GroupSize"); packet.ReadBit("Success"); } From 0dd0a451cb6395dc371fbf323dd8d02a54656fa8 Mon Sep 17 00:00:00 2001 From: Alica228 Date: Tue, 24 Mar 2026 11:17:28 +0200 Subject: [PATCH 2/3] lowest version that I've found in my files is 65560 --- WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs | 2 +- WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs index f0db2245a0..40be6540e5 100644 --- a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs @@ -152,7 +152,7 @@ public static void HandleMultiFloorNewFloor(Packet packet) public static void HandleEncounterstart(Packet packet) { packet.ReadInt32("DungeonEncounterID"); - if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_1_65818)) + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_0_65560)) packet.ReadInt16("DifficultyID"); else packet.ReadInt32("DifficultyID"); diff --git a/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs b/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs index 34fd30cdd4..e4293aeb6d 100644 --- a/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs @@ -208,7 +208,7 @@ public static void HandleEncounterStart(Packet packet) public static void HandleEncounterStop(Packet packet) { packet.ReadInt32("EncounterID"); - if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_1_65818)) + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_0_65560)) packet.ReadInt16("DifficultyID"); else packet.ReadInt32("DifficultyID"); From f3ae94bb80875021754bbfc6cdaf5dd84f951089 Mon Sep 17 00:00:00 2001 From: Shauren Date: Tue, 24 Mar 2026 21:32:36 +0100 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Shauren --- WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs | 2 +- WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs index 40be6540e5..669d3ab732 100644 --- a/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V10_0_0_46181/Parsers/InstanceHandler.cs @@ -152,7 +152,7 @@ public static void HandleMultiFloorNewFloor(Packet packet) public static void HandleEncounterstart(Packet packet) { packet.ReadInt32("DungeonEncounterID"); - if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_0_65560)) + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_0_65390)) packet.ReadInt16("DifficultyID"); else packet.ReadInt32("DifficultyID"); diff --git a/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs b/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs index e4293aeb6d..341418258f 100644 --- a/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs +++ b/WowPacketParserModule.V6_0_2_19033/Parsers/InstanceHandler.cs @@ -208,7 +208,7 @@ public static void HandleEncounterStart(Packet packet) public static void HandleEncounterStop(Packet packet) { packet.ReadInt32("EncounterID"); - if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_0_65560)) + if (ClientVersion.AddedInVersion(ClientVersionBuild.V12_0_0_65390)) packet.ReadInt16("DifficultyID"); else packet.ReadInt32("DifficultyID");