From 984cdd8b5a834f46f283afd04219d7aedbbe4082 Mon Sep 17 00:00:00 2001 From: LekoArts Date: Mon, 12 Aug 2024 12:53:21 +0200 Subject: [PATCH 1/4] handle nikos TODO :P --- packages/clerk-js/src/utils/assertNoLegacyProp.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/clerk-js/src/utils/assertNoLegacyProp.ts b/packages/clerk-js/src/utils/assertNoLegacyProp.ts index 50a51d04e56..a574b8d9e2f 100644 --- a/packages/clerk-js/src/utils/assertNoLegacyProp.ts +++ b/packages/clerk-js/src/utils/assertNoLegacyProp.ts @@ -5,9 +5,8 @@ export function assertNoLegacyProp(props: Record) { const legacyProp = Object.keys(props).find(key => legacyProps.includes(key)); if (legacyProp && props[legacyProp]) { - // TODO: @nikos update with the docs link logger.warnOnce( - `Clerk: The prop "${legacyProp}" is deprecated and should be replaced with the new "fallbackRedirectUrl" or "forceRedirectUrl" props instead.`, + `Clerk: The prop "${legacyProp}" is deprecated and should be replaced with the new "fallbackRedirectUrl" or "forceRedirectUrl" props instead. Learn more: https://clerk.com/docs/guides/custom-redirects#redirect-url-props`, ); } } @@ -19,9 +18,8 @@ export function warnForNewPropShadowingLegacyProp( legacyValue: string | undefined | null, ) { if (newValue && legacyValue) { - // TODO: @nikos update with the docs link logger.warnOnce( - `Clerk: The "${newKey}" prop ("${newValue}") has priority over the legacy "${legacyKey}" (or "redirectUrl") ("${legacyValue}"), which will be completely ignored in this case. "${legacyKey}" (or "redirectUrl" prop) should be replaced with the new "fallbackRedirectUrl" or "forceRedirectUrl" props instead.`, + `Clerk: The "${newKey}" prop ("${newValue}") has priority over the legacy "${legacyKey}" (or "redirectUrl") ("${legacyValue}"), which will be completely ignored in this case. "${legacyKey}" (or "redirectUrl" prop) should be replaced with the new "fallbackRedirectUrl" or "forceRedirectUrl" props instead. Learn more: https://clerk.com/docs/guides/custom-redirects#redirect-url-props`, ); } } From f8b6d337085aa39c0ce4873041ec70027418f488 Mon Sep 17 00:00:00 2001 From: LekoArts Date: Mon, 12 Aug 2024 12:53:37 +0200 Subject: [PATCH 2/4] add warning about dev instance --- packages/clerk-js/src/core/clerk.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/clerk-js/src/core/clerk.ts b/packages/clerk-js/src/core/clerk.ts index 4b0ca388918..2fc0c6794cc 100644 --- a/packages/clerk-js/src/core/clerk.ts +++ b/packages/clerk-js/src/core/clerk.ts @@ -14,6 +14,7 @@ import { proxyUrlToAbsoluteURL, stripScheme, } from '@clerk/shared'; +import { logger } from "@clerk/shared/logger" import { eventPrebuiltComponentMounted, TelemetryCollector } from '@clerk/shared/telemetry'; import type { ActiveSessionResource, @@ -271,6 +272,11 @@ export class Clerk implements ClerkInterface { return; } + // Log a development mode warning once + if (this.#instanceType === 'development') { + logger.warnOnce('Clerk: Clerk has been loaded with development keys. Development instances have strict usage limits and should not be used when deploying your application to production. Learn more: https://clerk.com/docs/deployments/overview') + } + this.#options = { ...defaultOptions, ...options, From d892329cb8bbaf4a08534dea9186df5550e5aa9d Mon Sep 17 00:00:00 2001 From: LekoArts Date: Mon, 12 Aug 2024 12:56:26 +0200 Subject: [PATCH 3/4] add changeset --- .changeset/modern-badgers-flash.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/modern-badgers-flash.md diff --git a/.changeset/modern-badgers-flash.md b/.changeset/modern-badgers-flash.md new file mode 100644 index 00000000000..af8abba16f9 --- /dev/null +++ b/.changeset/modern-badgers-flash.md @@ -0,0 +1,5 @@ +--- +"@clerk/clerk-js": patch +--- + +Add development mode warning in the browser console when `load()` happens. Companion PR for [Add dev mode warning to components](https://github.com/clerk/javascript/pull/3870). From f6939fad303cc3c394f937f1f828f27790903614 Mon Sep 17 00:00:00 2001 From: LekoArts Date: Mon, 12 Aug 2024 13:58:09 +0200 Subject: [PATCH 4/4] prettier formatting --- packages/clerk-js/src/core/clerk.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/clerk-js/src/core/clerk.ts b/packages/clerk-js/src/core/clerk.ts index 2fc0c6794cc..ac4b6a44a54 100644 --- a/packages/clerk-js/src/core/clerk.ts +++ b/packages/clerk-js/src/core/clerk.ts @@ -14,7 +14,7 @@ import { proxyUrlToAbsoluteURL, stripScheme, } from '@clerk/shared'; -import { logger } from "@clerk/shared/logger" +import { logger } from '@clerk/shared/logger'; import { eventPrebuiltComponentMounted, TelemetryCollector } from '@clerk/shared/telemetry'; import type { ActiveSessionResource, @@ -274,7 +274,9 @@ export class Clerk implements ClerkInterface { // Log a development mode warning once if (this.#instanceType === 'development') { - logger.warnOnce('Clerk: Clerk has been loaded with development keys. Development instances have strict usage limits and should not be used when deploying your application to production. Learn more: https://clerk.com/docs/deployments/overview') + logger.warnOnce( + 'Clerk: Clerk has been loaded with development keys. Development instances have strict usage limits and should not be used when deploying your application to production. Learn more: https://clerk.com/docs/deployments/overview', + ); } this.#options = {