From e99eb555407d22b67ccd4ac15001b6f4919a2ec4 Mon Sep 17 00:00:00 2001 From: A0su Date: Tue, 24 Mar 2026 13:03:08 -0500 Subject: [PATCH 1/7] add null check for sym_new(ctx) in make_bottom --- Python/optimizer_symbols.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Python/optimizer_symbols.c b/Python/optimizer_symbols.c index 2a8d8c45c588ba..32e8c2dbde63b8 100644 --- a/Python/optimizer_symbols.c +++ b/Python/optimizer_symbols.c @@ -1684,6 +1684,9 @@ static JitOptSymbol * make_bottom(JitOptContext *ctx) { JitOptSymbol *sym = sym_new(ctx); + if (res == NULL) { + return out_of_space_ref(ctx); + } sym->tag = JIT_SYM_BOTTOM_TAG; return sym; } From 8d0ef9d8d96258bc79fe6eb079e77d650d07c0d0 Mon Sep 17 00:00:00 2001 From: A0su Date: Tue, 24 Mar 2026 14:32:47 -0500 Subject: [PATCH 2/7] fix typo on var name --- Python/optimizer_symbols.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Python/optimizer_symbols.c b/Python/optimizer_symbols.c index 32e8c2dbde63b8..c4e586dae0292d 100644 --- a/Python/optimizer_symbols.c +++ b/Python/optimizer_symbols.c @@ -1684,7 +1684,7 @@ static JitOptSymbol * make_bottom(JitOptContext *ctx) { JitOptSymbol *sym = sym_new(ctx); - if (res == NULL) { + if (sym == NULL) { return out_of_space_ref(ctx); } sym->tag = JIT_SYM_BOTTOM_TAG; From d2ff2c57ec9f0ab394fdae98b5256c4ab9da8c87 Mon Sep 17 00:00:00 2001 From: A0su Date: Tue, 24 Mar 2026 15:53:54 -0500 Subject: [PATCH 3/7] use out_of_space instead of out_of_space_ref to align return type --- Python/optimizer_symbols.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Python/optimizer_symbols.c b/Python/optimizer_symbols.c index c4e586dae0292d..0bc3c5055812c4 100644 --- a/Python/optimizer_symbols.c +++ b/Python/optimizer_symbols.c @@ -1685,7 +1685,7 @@ make_bottom(JitOptContext *ctx) { JitOptSymbol *sym = sym_new(ctx); if (sym == NULL) { - return out_of_space_ref(ctx); + return out_of_space(ctx); } sym->tag = JIT_SYM_BOTTOM_TAG; return sym; From a6a2fdef2bdbedbc61e10fc320ca25fd8d37efc7 Mon Sep 17 00:00:00 2001 From: A0su Date: Thu, 26 Mar 2026 11:18:55 -0500 Subject: [PATCH 4/7] add blurb --- .../2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst new file mode 100644 index 00000000000000..3b52de7969b4a0 --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst @@ -0,0 +1 @@ +Add a null check for :func:`sym_new(ctx)` in :func:`make_bottom` From e76d0ea0c53c33fe8498f13e3c7d26b2c447bd71 Mon Sep 17 00:00:00 2001 From: A0su Date: Thu, 26 Mar 2026 16:03:49 -0500 Subject: [PATCH 5/7] update blurb based on comment --- .../2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst index 3b52de7969b4a0..19d16734945cbd 100644 --- a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst @@ -1 +1 @@ -Add a null check for :func:`sym_new(ctx)` in :func:`make_bottom` +Adds a null check to handle when the JIT optimizer runs out of space when dealing with contradictions in :func:`make_bottom` From 5a393d26ebd827449506a55bab5d94ba169d28f9 Mon Sep 17 00:00:00 2001 From: A0su Date: Thu, 26 Mar 2026 22:38:18 -0500 Subject: [PATCH 6/7] fix blurb based :func: --- .../2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst index 19d16734945cbd..ab530efed4f8e3 100644 --- a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst @@ -1 +1 @@ -Adds a null check to handle when the JIT optimizer runs out of space when dealing with contradictions in :func:`make_bottom` +Adds a null check to handle when the JIT optimizer runs out of space when dealing with contradictions in `make_bottom` From 1ec767b501859e7680f105ac598e7fd9883af534 Mon Sep 17 00:00:00 2001 From: Brandon Date: Thu, 26 Mar 2026 22:42:21 -0500 Subject: [PATCH 7/7] Update 2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst Co-authored-by: AN Long --- .../2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst index ab530efed4f8e3..7cf5edfe8c6c6f 100644 --- a/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst +++ b/Misc/NEWS.d/next/Core_and_Builtins/2026-03-26-11-18-45.gh-issue-146388.O0u1c3.rst @@ -1 +1 @@ -Adds a null check to handle when the JIT optimizer runs out of space when dealing with contradictions in `make_bottom` +Adds a null check to handle when the JIT optimizer runs out of space when dealing with contradictions in ``make_bottom``.