From 51525645f56218916730ac1db734bf1e785eff97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Rancoud?= Date: Thu, 24 Apr 2025 02:39:43 +0200 Subject: [PATCH] chore: remove comments about phpcs --- .gitattributes | 1 - .php-cs-fixer.php | 2 +- tests/ApplicationTest.php | 14 +++++++------- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/.gitattributes b/.gitattributes index e99ca02..47bd936 100644 --- a/.gitattributes +++ b/.gitattributes @@ -6,5 +6,4 @@ /.gitattributes export-ignore /.gitignore export-ignore /.php-cs-fixer.php export-ignore -/phpcs.xml export-ignore /phpunit.xml export-ignore diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 688a26a..0b39c42 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -111,7 +111,7 @@ 'no_empty_comment' => true, 'no_trailing_whitespace_in_comment' => true, 'single_line_comment_spacing' => true, - 'single_line_comment_style' => ['comment_types' => ['asterisk', 'hash']] + 'single_line_comment_style' => ['comment_types' => ['hash']] ]; $constantNotationRules = [ diff --git a/tests/ApplicationTest.php b/tests/ApplicationTest.php index 58f09b2..a06d108 100644 --- a/tests/ApplicationTest.php +++ b/tests/ApplicationTest.php @@ -172,7 +172,7 @@ public function testGetInvalidFolder(): void #[RunInSeparateProcess] public function testConstructorEnvironment(): void { - $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_empty.env')); // phpcs:ignore + $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_empty.env')); static::assertInstanceOf(Application::class, $app); } @@ -187,7 +187,7 @@ public function testConstructorEnvironmentBadTimezone(): void $this->expectException(ApplicationException::class); $this->expectExceptionMessage('Invalid timezone: invalid. Check DateTimeZone::listIdentifiers()'); - new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_bad_timezone.env')); // phpcs:ignore + new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_bad_timezone.env')); } /** @@ -197,7 +197,7 @@ public function testConstructorEnvironmentBadTimezone(): void #[RunInSeparateProcess] public function testConstructorEnvironmentGoodTimezone(): void { - $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_good_timezone.env')); // phpcs:ignore + $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_good_timezone.env')); static::assertInstanceOf(Application::class, $app); } @@ -212,7 +212,7 @@ public function testConstructorEnvironmentInvalidRoutes(): void $this->expectException(ApplicationException::class); $this->expectExceptionMessage('Invalid routes'); - new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_routes.env')); // phpcs:ignore + new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_routes.env')); } /** @@ -225,7 +225,7 @@ public function testConstructorEnvironmentInvalidRoute(): void $this->expectException(ApplicationException::class); $this->expectExceptionMessage('Invalid route file'); - new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_route.env')); // phpcs:ignore + new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_invalid_route.env')); } /** @@ -289,7 +289,7 @@ public function testRunRouterException404Invalid(): void $this->expectException(RouterException::class); $this->expectExceptionMessage('The default404 is invalid'); - $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env')); // phpcs:ignore + $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env')); $request = $this->getRequest('GET', '/no_handle'); $app->run($request); } @@ -305,7 +305,7 @@ public function testRunRouterException(): void $this->expectException(RouterException::class); $this->expectExceptionMessage('The default404 is invalid'); - $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env')); // phpcs:ignore + $app = new Application($this->getFoldersWithTestEnv(), new Environment([$this->testsEnvFolder], 'test_router_404.env')); $request = $this->getRequest('GET', '/no_handle'); $app->run($request); }