Fix/reminderbug 修复定时任务的bug (#349)

* update

* fix: 修复cron任务执行时的agent引用问题并优化提醒行为

1. 修复 AttributeError: 'function' object has no attribute 'process_direct'
   - 使用 mutable holder pattern 解决 agent 初始化顺序问题
   - 在 prepare_agent_loop 中设置 cron._agent_holder['agent'] 引用

2. 优化 cron 提醒的 agent 行为
   - 给 agent 发送明确的 [CRON TASK] 指令
   - 告知 agent 这是定时任务，不是用户对话输入
   - 避免 agent 把提醒消息当作用户问题来回复

Author: chenjw

bot/.gitignore

@@ -35,5 +35,6 @@ build/
 coverage/
 
 test/
+data/
 
 CLAUDE.md

bot/vikingbot/cli/commands.py

@@ -257,6 +257,9 @@ def prepare_agent_loop(config, bus, session_manager, cron):
         sandbox_manager=sandbox_manager,
         config=config,
     )
+    # Set the agent reference in cron if it uses the holder pattern
+    if hasattr(cron, '_agent_holder'):
+        cron._agent_holder['agent'] = agent
     return agent
 
 
@@ -265,12 +268,35 @@ def prepare_cron(bus) -> CronService:
     cron_store_path = get_data_dir() / "cron" / "jobs.json"
     cron = CronService(cron_store_path)
 
+    # Use a mutable holder for the agent reference
+    agent_holder = {"agent": None}
+
     # Set cron callback (needs agent)
     async def on_cron_job(job: CronJob) -> str | None:
         """Execute a cron job through the agent."""
         session_key = SessionKey(**json.loads(job.payload.session_key_str))
-        response = await agent.process_direct(
-            job.payload.message,
+        message = job.payload.message
+
+        if agent_holder["agent"] is None:
+            raise RuntimeError("Agent not initialized yet")
+
+        # Clear instructions: let agent know this is a cron task to deliver
+        cron_instruction = f"""[CRON TASK]
+This is a scheduled task triggered by cron job: '{job.name}'
+Your task is to deliver the following reminder message to the user.
+
+IMPORTANT:
+- This is NOT a user message - it's a scheduled reminder you need to send
+- You should acknowledge/confirm the reminder and send it in a friendly way
+- DO NOT treat this as a question from the user
+- Simply deliver the reminder message as requested
+
+Reminder message to deliver:
+\"\"\"{message}\"\"\"
+"""
+
+        response = await agent_holder["agent"].process_direct(
+            cron_instruction,
             session_key=session_key,
         )
         if job.payload.deliver:
@@ -285,6 +311,7 @@ async def on_cron_job(job: CronJob) -> str | None:
         return response
 
     cron.on_job = on_cron_job
+    cron._agent_holder = agent_holder
 
     cron_status = cron.status()
     if cron_status["jobs"] > 0: