Skip to content

[O2B-536] Clean selection model #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martinboulais wants to merge 5 commits into
base: main
Choose a base branch
from

Clean selection model

e9407a6
Select commit
Loading
Failed to load commit list.
Draft

[O2B-536] Clean selection model #1835

Clean selection model
e9407a6
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Apr 1, 2026 in 1s

44.54% (-0.04%) compared to 4b629d2

View this Pull Request on Codecov

44.54% (-0.04%) compared to 4b629d2

Details

Codecov Report

❌ Patch coverage is 0% with 175 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.54%. Comparing base (4b629d2) to head (e9407a6).
⚠️ Report is 211 commits behind head on main.

Files with missing lines Patch % Lines
...common/selection/FilterableRemoteSelectionModel.js 0.00% 52 Missing ⚠️
...nts/common/selection/dropdown/selectionDropdown.js 0.00% 24 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 20 Missing ⚠️
...ic/components/common/selection/selectionOptions.js 0.00% 16 Missing ⚠️
...ublic/components/common/selection/picker/picker.js 0.00% 9 Missing ⚠️
...lags/GaqFlags/gaqDetectorsSelectionModalTrigger.js 0.00% 8 Missing ⚠️
lib/public/views/Logs/Create/LogReplyModel.js 0.00% 7 Missing ⚠️
...lic/views/Logs/Create/TemplatedLogCreationModel.js 0.00% 7 Missing ⚠️
...ponents/common/selection/picker/pickerSelection.js 0.00% 6 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 6 Missing ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
- Coverage   44.57%   44.54%   -0.04%     
==========================================
  Files        1010     1008       -2     
  Lines       16959    16905      -54     
  Branches     3046     3017      -29     
==========================================
- Hits         7560     7530      -30     
+ Misses       9399     9375      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov