[PWGHF] Pt shape study#15613
Draft
deependra170598 wants to merge 4 commits intoAliceO2Group:masterfrom
Draft
Conversation
|
O2 linter results: ❌ 0 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @jessica, @stefanopolitano, @fgrosa, @xinyepeng
Could you please review the following PR?
In this PR, I tried to make 3 modifications...
for the last part, I explain what I did.
It is fully configurable to choose which way we want to apply weight.
Two main configurables:
ptShapeStudy(bool)useWeightOnline(bool)Online Weighting (when
useWeightOnlineis true)Step 1. First weights (with finer pt bins) to be computed with the combination of https://github.com/AliceO2Group/O2Physics/blob/master/PWGHF/Tasks/taskMcGenPtRapShapes.cxx and FONNL page.
Step 2. Weights to be uploaded to ccdb. These weights will be fetched online.
Step 3. For prompt, the weight will be fetched corresponding to pT of current Dstar candidate in loop, then weighted entry is filled in the THnSparse which has wider pT bins for Dstar such that sub-bins are filled in the same corresponding correct wide pT bin of THnSparse. Here ROOT will do the following addition over sub-bins for us.
Step 4. For Non-prompt, the weight will be fetched corresponding to pT of B mother of current Dstar candidate in the loop. Then the weighted entry for each sub-bins will be filled in the current wide pT bins of Dstar. Here there should not be a confusion if we are filling in incorrect pT bin of Dstar. pT (of Dstar) of wide bin in which weighted entry is to be filled is solely determined by pT of current Dstar candidate in loop not by pT of mother B hadron. In this case following mathematical addition will be done by ROOT for us.
N_reco (pTD* bin) = sum_{pTB bins} w(pT B bin) x N_reco (pT B) and same for N_genNote: Positive side of online weight is that No extra axis has been added to THnSparse which can cause memory issue as in light ion or heavy ion we are seeing the memory issue for the same task. Other is our post-processing framework will remain unchanged.
Offline Weighting (when
useWeightOnlineis false)Additional THnSparse have been added with fine binned pT axis for either prompt D* or for mother B hadron. Structure of original ThnSparse have not been modified so that those analysers who are already using the same task for analysis on other systems are not get effected and their post processing remain same.
Thanks for review and let me if any modification is needed.