Skip to content

[PWGLF] Update v0cascadesqa.cxx#15615

Merged
romainschotter merged 8 commits intomasterfrom
romainschotter-patch-2
Apr 1, 2026
Merged

[PWGLF] Update v0cascadesqa.cxx#15615
romainschotter merged 8 commits intomasterfrom
romainschotter-patch-2

Conversation

@romainschotter
Copy link
Copy Markdown
Collaborator

  • group configurables into configurable groups
  • add event selections
  • add V0/cascade selections

@github-actions github-actions bot added the pwglf label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

O2 linter results: ❌ 16 errors, ⚠️ 10 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Update v0cascadesqa.cxx [PWGLF] Update v0cascadesqa.cxx Apr 1, 2026
@romainschotter romainschotter enabled auto-merge (squash) April 1, 2026 20:45
alibuild
alibuild previously approved these changes Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 1, 2026

Error while checking build/O2Physics/o2 for 9028f6e at 2026-04-01 23:59:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/v0cascadesqa.cxx:1058:26: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/v0cascadesqa.cxx:1061:26: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/v0cascadesqa.cxx:1064:29: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/QC/v0cascadesqa.cxx:1067:29: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @romainschotter.

@romainschotter romainschotter merged commit 29864e6 into master Apr 1, 2026
12 of 15 checks passed
@romainschotter romainschotter deleted the romainschotter-patch-2 branch April 1, 2026 22:30
Comment on lines +22 to +24
#include <cmath>
// #include <cstdlib>
#include "PWGLF/DataModel/LFStrangenessPIDTables.h"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't break the sorting.

Configurable<bool> cfgTreatLimitedAcceptanceAsBad{"cfgTreatLimitedAcceptanceAsBad", false, "reject all events where the detectors relevant for the specified Runlist are flagged as LimitedAcceptance"};
} rctConfigurations;

RCTFlagsChecker rctFlagsChecker{rctConfigurations.cfgRCTLabel.value};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include what you use.

histos_event.fill(HIST("hEventSelection"), 1 /* sel8 collisions */);
}

if (eventSelections.requireTriggerTVX && !collision.selection_bit(aod::evsel::kIsTriggerTVX)) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include what you use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants