Skip to content

[ALICE3] Fix compilation errors in macros #15631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Apr 2, 2026
+2 −2
Merged

[ALICE3] Fix compilation errors in macros #15631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ALICE3/Macros/drawFastTracker.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

void drawFastTracker(float magneticField = 5.f, // in units of kGauss
const int nch = 100, // number of charged particles per unit rapidity
const int pdg = 211) // PDG code of the particle to track

Check failure on line 30 in ALICE3/Macros/drawFastTracker.C

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
{
TDatabasePDG* db = TDatabasePDG::Instance();
TParticlePDG* p = 0;
Expand Down Expand Up @@ -75,7 +75,7 @@
fastTracker.AddLayer("B11", 100., 250, x0OB, xrhoOB, resRPhiOB, resZOB, eff, 1);
} else {
std::vector<float> pixelRes{0.025, 0.025, 0.01, 0.01};
fastTracker.AddSiliconALICE3v4(pixelRes);
// fastTracker.AddSiliconALICE3v4(pixelRes); // FIXME
}

fastTracker.Print();
Expand Down Expand Up @@ -111,7 +111,7 @@
continue;
}

for (int trial = 0; trial < 200; trial++) {

Check failure on line 114 in ALICE3/Macros/drawFastTracker.C

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
hEfficiency->Fill(fastTracker.FastTrack(trkIn, trkOut, nch) > 0, pt);
}
int status = 4;
Expand Down
2 changes: 1 addition & 1 deletion ALICE3/Macros/testFastTracker.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void testFastTracker(std::string geometryFile = "a3geo.ini")
// auto& ccdb = o2::ccdb::BasicCCDBManager::instance();
// ccdb.setURL("http://alice-ccdb.cern.ch");
o2::fastsim::FastTracker fastTracker;
fastTracker.AddGenericDetector(geometryFile);
// fastTracker.AddGenericDetector(geometryFile); // FIXME
// fastTracker.AddGenericDetector(geometryFile, &ccdb);
fastTracker.Print();
}
Loading