Skip to content

fix noise module #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anschaible wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix noise module #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d7cd1
fix noise module, change to jnp.nanmeadian
anschaible Apr 1, 2026
33cb6fc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ notebooks/frames
rubix/**/*.ipynb

rubix/spectra/ssp/templates/fsps.h5
rubix/spectra/ssp/templates/*
rubix/spectra/ssp/templates/*.gz
rubix/spectra/ssp/templates/*fits.gz
rubix/spectra/cue/cue/*
Expand Down
5 changes: 3 additions & 2 deletions rubix/telescope/noise/noise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,9 @@ def calculate_S2N(
nonzero_mask = flux_image > 0

# Calculate the median flux value where the flux is non-zero
median_flux = jnp.median(jnp.where(nonzero_mask, flux_image, jnp.nan))
median_flux = jnp.nan_to_num(median_flux, nan=0.0)
# median_flux = jnp.median(jnp.where(nonzero_mask, flux_image, jnp.nan))
# median_flux = jnp.nan_to_num(median_flux, nan=0.0)
median_flux = jnp.nanmedian(jnp.where(nonzero_mask, flux_image, jnp.nan))

# Calculate the noise factor
noise_factor = jnp.sqrt(median_flux) / observation_signal_to_noise
Expand Down
Loading