Merged
Conversation
…cts for SAML 2.0 messaging. A full Signed SAML response with assertion ( encrypted assertion option).
brandonros
approved these changes
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Feature Addition:
The current node-saml allows for:
Feature enhancement allows for a new Full SAML 2.0 Response:
This is accomplished by using an optional switch for 100% backward compatibility:
options.createSignedSamlResponse
If this switch is active, an additional options check is performed on insuring a second new option, destination is included.
The very important SAML response document id is derived from (options.uid || utils.uid(32))
so when the SAML is signed the 'ID' aligns with the reference 'URI'.
Unit tests were also updated to insure compatibility with existing code tests.
All additional test +:
saml 2.0 full SAML response
✓ should create a saml 2.0 signed response including plain assertion
✓ ...with attributes
✓ should insure SAML response attribute [ID] matches signature reference attribute [URI]
✓ should require a [Destination] attribute on SAML Response element
Ready for review. In addition, this code update was moved back and forth between node-sso-formatter to insure all unit test and e2e tests were successful.
Svet and Brian also assisted in this work.
Thank you.
Any questions: Jon Lindsey