feat(abstract-utxo): deprecate legacy transaction signing#8335
Draft
OttoAllmendinger wants to merge 2 commits intomasterfrom
Draft
feat(abstract-utxo): deprecate legacy transaction signing#8335OttoAllmendinger wants to merge 2 commits intomasterfrom
OttoAllmendinger wants to merge 2 commits intomasterfrom
Conversation
Add `extractTransaction` option to control whether finalized PSBTs are extracted to legacy transaction format. When false, returns the finalized PSBT, preserving derivation info useful for testing. Default behavior (true) maintains backward compatibility by extracting to legacy format. Issue: BTC-2768 Co-authored-by: llm-git <llm-git@ttll.de>
Update `supportedTxFormats` default to disallow legacy format for user inputs while maintaining backward compatibility for internal operations like PSBT finalization. Update tests to reflect new restrictions and skip deprecated legacy format test cases. Issue: BTC-2768 Co-authored-by: llm-git <llm-git@ttll.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add restrictions and controls for legacy transaction format handling:
supportedTxFormatsdefault to disallow legacy formatdecodeTransactionto reject unsupported formatsextractTransactionoption to control whether finalized PSBTs areextracted to network broadcast transaction format. When false, returns
the finalized PSBT, preserving derivation info useful for testing.
Default behavior (true) maintains backward compatibility
handling for deprecated transactions
Issue: BTC-2768