feat(canton): implement getSignablePayload override for EdDSA extended payload#8337
Draft
feat(canton): implement getSignablePayload override for EdDSA extended payload#8337
Conversation
5326d63 to
d5c7249
Compare
d5c7249 to
0621452
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the upstream fix for Canton EdDSA signature verification by overriding
getSignablePayload()in the Canton coin class to construct the proper extended payload format.Problem
Canton's HSM must sign a structured payload containing transaction metadata concatenated with the signable hash, not just the hash alone. The base implementation was returning only the hash, causing signing/verification mismatches.
Solution
Override
getSignablePayload()in Canton coin to:Impact
Test Plan