Skip to content

Issue 2617 #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreiGorelov wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Issue 2617 #2633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c7460
Fix ConcurrentModificationException in AlphaTabRenderSurface placehol…
Mar 24, 2026
821427d
Fix Android resize throttle to run on main thread (prevent BoundsLook…
Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kotlin/src/android/src/main/java/alphaTab/EnvironmentPartials.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ internal class EnvironmentPartials {
print("Screen Size: ${AndroidEnvironment.screenWidth}x${AndroidEnvironment.screenHeight}");
}

private val throttleScope = CoroutineScope(Dispatchers.Default)
private val throttleScope = CoroutineScope(Dispatchers.Main)
internal fun throttle(toThrottle: () -> Unit, delay: Double): () -> Unit {
var job: Job? = null
return {
Expand Down
8 changes: 4 additions & 4 deletions packages/kotlin/src/android/src/main/java/alphaTab/platform/android/AlphaTabRenderSurface.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import android.widget.ScrollView
import java.io.Closeable
import java.lang.RuntimeException
import kotlin.contracts.ExperimentalContracts
import java.util.concurrent.CopyOnWriteArrayList

@ExperimentalUnsignedTypes
@ExperimentalContracts
Expand Down Expand Up @@ -44,7 +45,7 @@ internal class RenderPlaceholder(public var result: RenderFinishedEventArgs) : C
@ExperimentalContracts
internal class AlphaTabRenderSurface(context: Context, attributeSet: AttributeSet) :
View(context, attributeSet), View.OnScrollChangeListener {
private val _placeholders: ArrayList<RenderPlaceholder> = arrayListOf()
private val _placeholders: CopyOnWriteArrayList<RenderPlaceholder> = CopyOnWriteArrayList()
private val _resultIdToIndex: ObjectDoubleMap<String> = ObjectDoubleMap()

private var _totalWidth: Int = 0
Expand All @@ -65,11 +66,10 @@ internal class AlphaTabRenderSurface(context: Context, attributeSet: AttributeSe

public fun clearPlaceholders() {
_resultIdToIndex.clear()
val placeholder = _placeholders
for (p in placeholder) {
for (p in _placeholders) {
p.close();
}
placeholder.clear()
_placeholders.clear()
}

override fun onAttachedToWindow() {
Expand Down