fix(web): use Pointer Events API for touch support in HtmlElementContainer#2635
Open
omnisonic wants to merge 1 commit intoCoderLine:developfrom
Open
fix(web): use Pointer Events API for touch support in HtmlElementContainer#2635omnisonic wants to merge 1 commit intoCoderLine:developfrom
omnisonic wants to merge 1 commit intoCoderLine:developfrom
Conversation
…ainer Replace mousedown/mousemove/mouseup DOM event listeners with pointerdown/pointermove/pointerup in HtmlElementContainer. PointerEvent extends MouseEvent so BrowserMouseEventArgs remains fully compatible. Fixes CoderLine#2634 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2634
Proposed changes
Replace
mousedown/mousemove/mouseupDOM event listeners with the Pointer Events API (pointerdown/pointermove/pointerup) inHtmlElementContainer.ts.PointerEventextendsMouseEvent, soBrowserMouseEventArgsremains fully compatible —pageX,pageY,button, andpreventDefault()all work identically. The change is backward compatible for existing mouse-based users.Files changed:
packages/alphatab/src/platform/javascript/HtmlElementContainer.ts— swap event namespackages/alphatab/src/platform/javascript/BrowserMouseEventArgs.ts— update type annotation fromMouseEvent→PointerEventTested on:
beatMouseDown,beatMouseMove,beatMouseUpall confirmed firing on touchChecklist
Further details