fix(#974): add 39 example-db tests and 31 paper entries for reduction rules#997
Merged
fix(#974): add 39 example-db tests and 31 paper entries for reduction rules#997
Conversation
… entries Complete missing documentation and test coverage for 41 reduction rules shipped across PRs #777, #779, #804, and #972. Check 10: 39 new `test_find_rule_example_*` tests in example_db.rs covering all cross-problem reductions from the four PRs (ILP i32→bool excluded as a same-name variant edge). Check 11: 31 new `#reduction-rule(...)` entries in reductions.typ — 30 for cross-problem reductions (PRs #777, #779, #972) plus 1 for the ILP<i32> → ILP<bool> variant reduction via FBBT + truncated binary encoding. Closes #974 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 98.15% 98.16% +0.01%
==========================================
Files 896 896
Lines 91150 91715 +565
==========================================
+ Hits 89472 90036 +564
- Misses 1678 1679 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Wield, did you use the paper writing skills? why data are hard coded in examples? Example data in manual should be loaded from json, and json is dumped from example_db. |
…tion Upgrade the prose-only reduction-rule entry to include data-driven example with load-example binding, pred-commands, three construction steps, and multiplicity note. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…Path reduction Upgrade the prose-only reduction-rule entry with load-example data binding, pred-commands reproducibility block, and a 3-step worked example showing the vertex-splitting construction on a C4 cycle graph. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ravelingSalesman reduction Add data-driven example with load-example binding, pred-commands block, step-by-step construction walkthrough, and solution verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ctivityAugmentation reduction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t paper entry Upgrade the prose-only reduction-rule entry to include a data-driven worked example with load-example binding, pred-commands block, and step-by-step construction/verification using the C4 cycle graph fixture. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ng reduction Add data-driven example with load-example binding, pred-commands block, and step-by-step walkthrough showing the m=1 canonical instance with 3 elements, sizes (4,5,6), bound B=15 on 2 machines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…uction Upgrade the prose-only reduction-rule entry to include a data-driven worked example with load-example binding, pred-commands block, and step-by-step verification of the canonical witness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…inedScheduling reduction Also remove duplicate Partition -> ShortestWeightConstrainedPath entry that caused a label collision. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
You're right — the entries weren't generated with the paper writing skill. Fixing now: upgrading all 30 cross-problem entries to use |
…eleaseTimesAndDeadlines reduction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…uction Add data-driven example with load-example binding, pred-commands block, and step-by-step walkthrough showing source instance, job construction, separator window mechanism, and end-to-end solution verification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add data-driven worked example with load-example binding, pred-commands reproducibility block, step-by-step construction walkthrough, and end-to-end solution verification for the 3-SAT to k-clique reduction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…backArcSet reduction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ty reduction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…cking reduction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…over reduction Also remove duplicate ThreePartition -> FlowShopScheduling entry that caused a duplicate label compilation error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ts reduction Also remove duplicate ThreePartition -> FlowShopScheduling prose entry that was left over from a merge conflict. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Leftover from parallel worktree merge — the data-driven entry was placed at line ~10136 by the SAT→NAE agent, but the original prose-only entry at line ~13454 was not cleaned up. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resolve conflicts in docs/paper/reductions.typ: combine PR's 31 paper entries with main's batch-of-18 reduction rules. Fix HP→IST test to use updated variant (graph dimension added in main). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_find_rule_example_*lookup tests insrc/unit_tests/example_db.rscovering all cross-problem reductions from PRs feat: add 8 Tier 1a reduction rules (#770) #777, feat: add 12 Tier 1b high-confidence reduction rules (#770) #779, feat: add 11 Tier 1a + 1b medium-confidence reduction rules (#770) #804, feat: add 10 reduction rules (#770) #972#reduction-rule(...)entries indocs/paper/reductions.typ— 30 cross-problem reductions + 1 ILP → ILP variant reductionTest plan
make checkpasses (fmt + clippy + test)cargo test --lib --features example-db test_find_rule_example_— all 44 rule lookup tests passtypst compile docs/paper/reductions.typ— compiles with no errorscanonical_rule_examples_cover_exactly_authored_direct_reductions— coverage test passesCloses #974
🤖 Generated with Claude Code — Institute of Science Tokyo