Merged
Conversation
Contributor
Author
|
@cpr-bar could you take a look at this? I want to open another PR soon, and it would be much simpler if we can get this one merged first. |
For larger portals the referencing can take more than 30 seconds.
46b9aa3 to
f7d2ed5
Compare
Collaborator
|
Working on it. Sorry for the delay. |
Contributor
Author
thanks! I just rebased the branch on latest I'd be happy to have a short call to talk about next steps. I'm happy to contribute if we can speed things up. |
cpr-bar
approved these changes
Nov 27, 2025
Collaborator
|
It's now in main. Thanks again for your contribution. Yes, let's talk. I will send you a mail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pre-commit configuration including
ruffandisortmypyto check against incorrect type hintsThe GitHub actions will only start running after the merge.
If I remember correctly, only PRs by maintainers run GitHub Actions that were not present on the default branch already.
Changes to fix typing errors:
CRIController._wait_for_answerreturnedFalseon unknown message IDs → changed toreturn Noneto match the signatureCRIController.wait_for_kinematics_readyimplementation was not compatible with advertisedtimeout: float | Nonesignature → changed totimeout: floatCRIController.upload_filenever returnedTrueas described in the docstring → fixed