Skip to content

Dev -> main for mia #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BigSpaceships merged 2 commits into from
Mar 19, 2026
Merged

Dev -> main for mia #524

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e39640
fix dumb thing i did (#521)
BigSpaceships Mar 18, 2026
9d32319
Made it so mia can review, I messed up here (#523)
BigSpaceships Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions conditional/blueprints/major_project_submission.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,6 @@ def submit_major_project(user_dict=None):

# Delete the temp directory once all the files have been stored in S3
os.rmdir(temp_dir)
else:
log.error("Could not create temp directory for uploading files")
return jsonify({"success": False}), 500


# Send the slack ping only after we know that the data was properly saved to the DB
Expand All @@ -191,7 +188,7 @@ def submit_major_project(user_dict=None):
def major_project_review(user_dict=None):
log = logger.new(request=request, auth_dict=user_dict)

if not user_dict_is_eval_director(user_dict["account"]):
if not user_dict_is_eval_director(user_dict):
return redirect("/dashboard", code=302)

post_data = request.get_json()
Expand All @@ -200,7 +197,6 @@ def major_project_review(user_dict=None):

log.info(f"{status} Major Project ID: {pid}")

print(post_data)
MajorProject.query.filter(MajorProject.id == pid).update({"status": status})

db.session.flush()
Expand Down
Loading