Skip to content

Position interface update#18

Open
justinemajor wants to merge 17 commits intomainfrom
position_interface_update
Open

Position interface update#18
justinemajor wants to merge 17 commits intomainfrom
position_interface_update

Conversation

@justinemajor
Copy link
Copy Markdown
Collaborator

No description provided.

justinemajor and others added 15 commits August 7, 2025 14:57
however mapping function (when positions forced) does not seem to move the device
Now, I want to correct the size of the numericEntry (microstep_pixel), as well as make the increment work properly for this float.
We will need a notification for when the mapping experiment specifically is done. It would probably be a notif linked to the attribute did_complete_experiment more globally but containing the experiment title
@justinemajor justinemajor requested a review from dccote October 28, 2025 14:52
@dccote
Copy link
Copy Markdown
Contributor

dccote commented Mar 9, 2026

Review — create_positions_for_map retourne des valeurs hardcodées

Dans position_and_mapcontroller.py, le vrai return positions_list est commenté et remplacé par une liste hardcodée de debug :

# return positions_list

return [(10, 0, 0), (100, 0, 0), (0, 100, 0), (100, 100, 0)]

Fix suggéré : décommenter return positions_list et supprimer la ligne hardcodée :

return positions_list

dccote and others added 2 commits March 9, 2026 13:21
…hardcoded debug values

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
These parameters are now passed as arguments to create_positions_for_map.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants