computeLight_fp: fix compilation when r_highPrecisionRendering is disabled#1314
Merged
computeLight_fp: fix compilation when r_highPrecisionRendering is disabled#1314
Conversation
VReaperV
reviewed
Sep 19, 2024
illwieckz
force-pushed
the
illwieckz/nohighres
branch
from
2d924bc to
62ac30f
Compare
illwieckz
force-pushed
the
illwieckz/nohighres
branch
from
62ac30f to
ad43e76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compilation when
r_highPrecisionRenderingis disabled.I don't know if the fix is right, but it fixes building the
lightMappingGLSL and I see no visual bugs.What makes me doubt is that I replace a
sampler3Dwith anusampler3Dbut I don't know the difference.This fixes a bug introduced in f960177 from #1105: