Revert "Merge generic2D shader into generic"#1486
Closed
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Closed
Revert "Merge generic2D shader into generic"#1486slipher wants to merge 1 commit intoDaemonEngine:masterfrom
slipher wants to merge 1 commit intoDaemonEngine:masterfrom
Conversation
This reverts commit 7b21035. This is a loading time regression that causes several useless shader permutations to be built. With "Merge generic2D shader into generic": built 241 glsl shaders in 19483 msec Without it: built 224 glsl shaders in 18827 msec The GENERIC_2D macro would need to be removed to merge these without introducing unnecessary permutations.
Member
|
Oopsie. |
Contributor
|
Can probably be done with |
Contributor
|
Well, that or just temporarily skipping subgroup profiler. |
Member
Author
|
Superseded by #1487. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #1483.
This is a loading time regression that causes several useless shader permutations to be built.
With "Merge generic2D shader into generic":
built 241 glsl shaders in 19483 msec
Without it:
built 224 glsl shaders in 18827 msec
The GENERIC_2D macro would need to be removed to merge these without introducing unnecessary permutations.