Disable building of some impossible GLSL permutations#1928
Merged
slipher merged 2 commits intoDaemonEngine:for-0.56.0/syncfrom Mar 12, 2026
Merged
Disable building of some impossible GLSL permutations#1928slipher merged 2 commits intoDaemonEngine:for-0.56.0/syncfrom
slipher merged 2 commits intoDaemonEngine:for-0.56.0/syncfrom
Conversation
For checking if a macro can't be used without another macro, we can just use HasConflictingMacros(). No need to have separate functions to check flags that must be on and flags that must be off. The one override of MissesRequiredMacros wasn't even using it for the right thing (a global GL config setting instead of a macro).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grid deluxe mapping without grid lighting is impossible