renderer: use legacy weight calculation for GLSL 1.20, fix #490 ref #470 #479#491
Closed
illwieckz wants to merge 1 commit intoDaemonEngine:masterfrom
Closed
renderer: use legacy weight calculation for GLSL 1.20, fix #490 ref #470 #479#491illwieckz wants to merge 1 commit intoDaemonEngine:masterfrom
illwieckz wants to merge 1 commit intoDaemonEngine:masterfrom
Conversation
…ne#490 ref DaemonEngine#470 DaemonEngine#479 Code introduced in DaemonEngine#479 fixes bug described in DaemonEngine#470 but broke compatibility with GLSL 1.20 as described in DaemonEngine#490. This commit brings back the legacy weight calculation code as a fallback when running GLSL 1.20 GPUs (OpenGL 2.1). The new code is still used with newer GPUs as expected.
Member
|
I think we could find still other ways to express the calculation, without entering the unpleasant state of multiple implementations. |
Member
Author
|
I'm not that against multiple implementations if they are rare and short, but what annoys me the most is that it adds two tests in CPU code we can avoid (on GPU code it's pre-processed anyway). |
Member
|
Superseded by #498. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code introduced in #479 fixes bug described in #470 but broke compatibility with GLSL 1.20 as described in #490. This commit brings back the legacy weight calculation code as a fallback when running GLSL 1.20 GPUs (OpenGL 2.1). The new code is still used with newer GPUs as expected.