Correct relative mouse input handling

[necessarily-equal]

Closes #600. Hopefully for good this time.

[necessarily-equal]

I've tested this to work on SDL2.0.20, SDL2.0.22 and SDL main branch (as of libsdl-org/SDL@3807e95).

Testing with old SDL versions is left as an exercise for the reader ;-)

[slipher]

This patch breaks Mac by making it impossible to move the mouse outside the window. This is true with both SDL 2.0.12 and latest SDL.

[necessarily-equal]

@bmorel since you seem to use a minimalist X11 setup, you may want to try to see if this PR don't introduce some regression on your setup.

// work around X window managers and edge-based workspace flipping
// - without this, we get LeaveNotify, no mouse button events, EnterNotify;
//   we would likely miss some button presses and releases.
IN_CenterMouse();

I'd say you don't really have to try it either, you can also complain afterwards ;)

[slipher]

The workspace flipping thing described in the comment seems to be an xfce behavior. https://askubuntu.com/questions/891859/xubuntu-snap-to-window-switching-workspaces

[necessarily-equal]

Tested working by @IngarKCT. It also works for me and it fix a problem that totally breaks the game, so I'm merging this.

I'll have a look at the XFCE situation a bit later, to check if it is still a problem.

[necessarily-equal]

I've checked XFCE and I've ticked that thing in the parameters. I couldn't reproduce the bug with the fixed daemon.

…

On Mon, Jun 13 2022 at 15:36:29 -07:00:00, slipher ***@***.***> wrote: The workspace flipping thing described in the comment seems to be an xfce behavior. https://askubuntu.com/questions/891859/xubuntu-snap-to-window-switching-workspaces — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[necessarily-equal]

@Viech it would be nice if you could backport this to the AUR

This patch should* apply: cleanly sdl.patch.txt (although it was hand-edited, and is untested)