Remove the need for a picker id during classification#764
Open
stephen-riggs wants to merge 2 commits intomainfrom
Open
Remove the need for a picker id during classification#764stephen-riggs wants to merge 2 commits intomainfrom
stephen-riggs wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 49.46% 49.64% +0.17%
==========================================
Files 92 92
Lines 9793 9744 -49
Branches 1283 1274 -9
==========================================
- Hits 4844 4837 -7
+ Misses 4709 4667 -42
Partials 240 240 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserting the picker id into the
ParticleClassificationGrouptable in ispyb creates a race condition which we have previously worked around. Given the picker id is optional we should just not do this. Particularly needed for doppio live.May need a change to pato before this is safe to merge