Skip to content

Skip the loading of extra routers if an exception is encountered#767

Merged
tieneupin merged 1 commit intomainfrom
safely-skip-extra-routers
Mar 27, 2026
Merged

Skip the loading of extra routers if an exception is encountered#767
tieneupin merged 1 commit intomainfrom
safely-skip-extra-routers

Conversation

@tieneupin
Copy link
Copy Markdown
Contributor

Murfey has been configured to load additional routers from the entry point group "murfey.groups". However, these routers are only needed for a subset of the instruments we support, and for instruments that are missing the necessary machine configuration keys to run these extra routers, they crash and prevent the backend server from instantiating.

The most straightforward fix at present is to just log the failure of the extra router to initialise, and continue on with the start-up process. Eventually these add-on routers need to be configured such that receive the name of the instrument they are to support via a request from the client before proceeding with loading up the required configuration settings.

@tieneupin tieneupin requested a review from stephen-riggs March 27, 2026 11:07
@tieneupin tieneupin self-assigned this Mar 27, 2026
@tieneupin tieneupin added bug Something isn't working server Relates to the server component labels Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.29%. Comparing base (b9108c9) to head (5400537).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   49.31%   49.29%   -0.02%     
==========================================
  Files          92       92              
  Lines        9815     9818       +3     
  Branches     1296     1296              
==========================================
  Hits         4840     4840              
- Misses       4725     4728       +3     
  Partials      250      250              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit 7df6b28 into main Mar 27, 2026
17 checks passed
@tieneupin tieneupin deleted the safely-skip-extra-routers branch March 27, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants