Skip the loading of extra routers if an exception is encountered#767
Merged
Skip the loading of extra routers if an exception is encountered#767
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 49.31% 49.29% -0.02%
==========================================
Files 92 92
Lines 9815 9818 +3
Branches 1296 1296
==========================================
Hits 4840 4840
- Misses 4725 4728 +3
Partials 250 250 🚀 New features to boost your workflow:
|
stephen-riggs
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Murfey has been configured to load additional routers from the entry point group
"murfey.groups". However, these routers are only needed for a subset of the instruments we support, and for instruments that are missing the necessary machine configuration keys to run these extra routers, they crash and prevent the backend server from instantiating.The most straightforward fix at present is to just log the failure of the extra router to initialise, and continue on with the start-up process. Eventually these add-on routers need to be configured such that receive the name of the instrument they are to support via a request from the client before proceeding with loading up the required configuration settings.