Skip to content

Make the murfey client config file optional#768

Open
stephen-riggs wants to merge 3 commits intomainfrom
inst-server-args
Open

Make the murfey client config file optional#768
stephen-riggs wants to merge 3 commits intomainfrom
inst-server-args

Conversation

@stephen-riggs
Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs commented Mar 27, 2026

The /home/.murfey file should no longer be needed, as it only records the server and instrument names.
This PR removes the need for this file.

  • Adds a --server flag on instrument server startup to supply the backend url.
  • The need for the instrument name has been removed entirely.

If the --server flag is not provided we fall back to the config file.

@stephen-riggs stephen-riggs requested a review from tieneupin March 27, 2026 12:24
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 79.16667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.33%. Comparing base (b9108c9) to head (5d116b6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   49.31%   49.33%   +0.02%     
==========================================
  Files          92       92              
  Lines        9815     9828      +13     
  Branches     1296     1298       +2     
==========================================
+ Hits         4840     4849       +9     
- Misses       4725     4727       +2     
- Partials      250      252       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +108 to +109
def change_monitoring_end_time(timestamp):
prom.monitoring_end_time
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a stub for another PR?

Copy link
Copy Markdown
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out, Stephen. The PR looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants