Make the murfey client config file optional#768
Open
stephen-riggs wants to merge 3 commits intomainfrom
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 49.31% 49.33% +0.02%
==========================================
Files 92 92
Lines 9815 9828 +13
Branches 1296 1298 +2
==========================================
+ Hits 4840 4849 +9
- Misses 4725 4727 +2
- Partials 250 252 +2 🚀 New features to boost your workflow:
|
tieneupin
reviewed
Mar 27, 2026
tieneupin
reviewed
Mar 27, 2026
Comment on lines
+108
to
+109
| def change_monitoring_end_time(timestamp): | ||
| prom.monitoring_end_time |
Contributor
There was a problem hiding this comment.
Is this a stub for another PR?
tieneupin
approved these changes
Mar 27, 2026
Contributor
tieneupin
left a comment
There was a problem hiding this comment.
Thanks for sorting this out, Stephen. The PR looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /home/.murfey file should no longer be needed, as it only records the server and instrument names.
This PR removes the need for this file.
If the --server flag is not provided we fall back to the config file.