Conversation
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 87.36% 87.59% +0.23%
==========================================
Files 13 13
Lines 910 927 +17
==========================================
+ Hits 795 812 +17
Misses 115 115
Continue to review full report at Codecov.
|
This commit addresses both github issues #81 and #67. The arguments to the a and long record builder functions (`aIn`, `aOut`, `longIn`, `longOut`) are brought more into line with the arguments as used in the epics_device module. This means that extra unnamed arguments can be used to specify EGU and PREC (where appropriate), and for out records the DRV limits take precedence. As a side effect, the implementation of this is made closer to that in https://github.com/dls-controls/epics_device/
Previously all "in" records were filtered out of this test
AlexanderWells-diamond
left a comment
AlexanderWells-diamond
left a comment
There was a problem hiding this comment.
Changes seem good to me. Just a couple of clarifying questions.
There's no new tests, so I don't believe anything is currently exercising the _set_scalar_out_defaults function fully. It'd be good to see at least a trivial test that tries to set different DRVL/H and L/HOPR values and confirm the record is as expected. I don't know if there's any situations that might give invalid values (e.g. someone sets LOPR and HOPR the wrong way round) that may also warrant testing?
|
Regarding the lack of tests, I agree that it would be good to add some more tests. |
Also fix missing internal changelog links
2 participants
This commit addresses both github issues #81 and #67.
The arguments to the a and long record builder functions (
aIn,aOut,longIn,longOut) are brought more into line with the arguments asused in the epics_device module. This means that extra unnamed arguments
can be used to specify EGU and PREC (where appropriate), and for out
records the DRV limits take precedence.
As a side effect, the implementation of this is made closer to that in
https://github.com/dls-controls/epics_device/