Added default collapsed nodes method#24
Merged
javier-godoy merged 1 commit intomasterfrom Oct 14, 2020
Merged
Conversation
ngonzalezpazFC
force-pushed
the
issue/8-default-collapse-nodes
branch
from
90ac50e to
87ebbe3
Compare
javier-godoy
requested changes
Oct 5, 2020
Member
javier-godoy
left a comment
javier-godoy
left a comment
There was a problem hiding this comment.
LGTM - minor changes requested.
| @@ -1,5 +1,18 @@ | |||
| package com.flowingcode.vaadin.addons.orgchart; | |||
|
|
|||
| import com.fasterxml.jackson.core.JsonProcessingException; | |||
Member
There was a problem hiding this comment.
Please move the imports after the license text.
| import com.vaadin.flow.component.splitlayout.SplitLayout; | ||
| import com.vaadin.flow.component.splitlayout.SplitLayout.Orientation; | ||
| import com.vaadin.flow.router.Route; | ||
| import java.util.Arrays; |
Member
There was a problem hiding this comment.
Please do not reorder the imports
ngonzalezpazFC
force-pushed
the
issue/8-default-collapse-nodes
branch
from
87ebbe3 to
f547a57
Compare
javier-godoy
requested changes
Oct 8, 2020
| import com.vaadin.flow.component.dependency.StyleSheet; | ||
| import com.vaadin.flow.component.html.Div; | ||
| import com.vaadin.flow.shared.Registration; | ||
| import java.util.List; |
ngonzalezpazFC
force-pushed
the
issue/8-default-collapse-nodes
branch
from
f547a57 to
387d32d
Compare
javier-godoy
previously approved these changes
Oct 8, 2020
javier-godoy
dismissed
their stale review
Needs to be rebased due to conflicts with master
javier-godoy
previously approved these changes
Oct 8, 2020
ngonzalezpazFC
force-pushed
the
issue/8-default-collapse-nodes
branch
from
99148b3 to
a9fd8be
Compare
javier-godoy
requested changes
Oct 14, 2020
src/test/java/com/flowingcode/vaadin/addons/orgchart/DemoView.java
Outdated
Show resolved
Hide resolved
ngonzalezpazFC
force-pushed
the
issue/8-default-collapse-nodes
branch
from
a9fd8be to
fe6bb03
Compare
javier-godoy
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8