Merged
Conversation
Type 'undefined' is not assignable to type 'number'.
The second parameter in CustomKeyEventHandlerRegistry.register can be undefined.
The parameter of registerCsiHandler must return boolean, but the existing helper functions returned void (and relied on !!undefined==false).
The parameter of cursorBackwardWrapped, cursorForwardWrapped and deleteChar is optional and defaults to 0.
paodb
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step on refactoring TS sources so that they can be compiled with the default settings from Vaadin 23.3.0/24.
So far, we still rely on disabling noImplicitAny, noImplicitThis and strictPropertyInitialization checks; and there are some import issues that will have to be addressed later.
These changes are compatible with Vaadin 22 (it passes all the integration tests for Vaadin 22 and 24), hence no need for a new major version so far.
Related to #64