Close census connection in extract_czi_markers#8
Open
LiudengZhang wants to merge 1 commit intoGenentech:mainfrom
Open
Close census connection in extract_czi_markers#8LiudengZhang wants to merge 1 commit intoGenentech:mainfrom
LiudengZhang wants to merge 1 commit intoGenentech:mainfrom
Conversation
cellxgene_census.open_soma() was never closed in extract_czi_markers, leaking the SOMA connection. Wrap the census usage in try/finally to ensure census.close() is always called, matching the pattern already used in download_czi_reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cellxgene_census.open_soma()inextract_czi_markerswas never closed, leaking the SOMA connection. This wraps the census usage intry/finallyto ensurecensus.close()is always called, matching the pattern already used indownload_czi_referencein the same file.