Skip to content

prepare utils for pypi distribution #5848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leahecole merged 3 commits into from
May 19, 2021
Merged

prepare utils for pypi distribution #5848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2c68d6
prepare utils for pypi distribution
leahecole May 19, 2021
85fcfa7
address setup.py nits
leahecole May 19, 2021
a601a7f
Merge branch 'master' into package-dag-test-utils
leahecole May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer/dag_test_utils/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This package is used internally to unit test the validity of all Cloud Composer

Add the following to your `requirements-test.txt` file:

`git+https://github.com/GoogleCloudPlatform/python-docs-samples.git#egg=dag_test_utils&subdirectory=composer/dag_test_utils`
`cloud_composer_dag_test_utils`
Copy link
Contributor

@crwilcox crwilcox May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should google be in the package name or is this agnostic to our stuffs?

Copy link
Collaborator Author

@leahecole leahecole May 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, it's agnostic to our stuff, though I could envision it being expanded to be more composer-y in the future. I wasn't sure if there were restrictions on using google in the package name - I'm happy to add it if you think it's appropriate here

Copy link
Contributor

@crwilcox crwilcox May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could go either way on this. I tend to think being upfront that "this is a google package" is an alright thing, but could also think that by not including google in the name it is more likely to be 'hidden' when folks search for things. :)

Copy link
Collaborator Author

@leahecole leahecole May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! I think I'll keep it as is for now for that 'hidden' reason


Import the internal unit testing module

Expand Down
3 changes: 3 additions & 0 deletions composer/dag_test_utils/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["setuptools", "wheel"]
build-backend = "setuptools.build_meta"
10 changes: 5 additions & 5 deletions composer/dag_test_utils/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@
from setuptools import setup

setup(
name="dag_test_utils",
name="cloud_composer_dag_test_utils",
version="0.0.1",
url="git@github.com:GoogleCloudPlatform/python-docs-samples.git#egg=dag_test_utils&subdirectory=composer/dag_test_utils",
author="Google Cloud Platform",
description="Utility used to unit test example Apache Airflow DAGs",
url="https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/composer/dag_test_utils",
author="Google LLC",
description="Utility used to unit test example Apache Airflow DAGs for Google Cloud Composer. This is not an officially supported Google product.",
packages=find_packages(),
py_modules=['internal_unit_testing'],
install_requires=['apache-airflow[gcp]']
install_requires=['apache-airflow[google]==1.10.15']
)