Conversation
This reverts commit 6bee904.
ashayp22
left a comment
There was a problem hiding this comment.
QR Scanner works perfectly, great work Aryan😄!
I left some inline comments, but they should be quick to fix.
After you finish up with closing the QR scanner after scanning a code, I can take a look at any new code and then you can merge ✅
|
@ashayp22 I've implemented your requested changes. I also updated the branch to the latest version of dev to resolve a merge conflict. Just wanted to let you know that for some reason, the latest version of dev isn't building on my MacBook properly, and I'm getting an error that it isn't able to load one of the assets you added. Here's a screenshot: |
@ifisq I deleted the Matching asset since we no longer will be using it. You can replace that line with: |
There was a problem hiding this comment.
One more tiny change: can you make the color of the closeButton black?
After that, feel free to go ahead and merge!
Update: Sorry, one more thing: I noticed that if the user
- Goes to the Profile page
- Clicks the QR Scanner button and scans a QR code
- Returns back to the Profile page after the QR scanner is closed.
The points aren't updated on the Profile Page.
I think this is because reloadProfile() function in HIProfileViewController isn't called after the QR scanner is closed. Can you think of a way to call that function after the user successfully scans a QR code?
|
@ashayp22 i've added the requested changes, let me know if there's anything else i need to do before merging. |
ashayp22
left a comment
There was a problem hiding this comment.
Looks good, you can merge

Description
Fixes #135
Todos
Screenshots
I don't have a screenshot of this working since we don't have any usable QR codes yet. The only added page is a camera for the QR scanner.