Skip to content
This repository was archived by the owner on Oct 12, 2025. It is now read-only.

QR Scanner#412

Merged
ifisq merged 16 commits intodevfrom
aryan/qr-scanner
Jan 20, 2022
Merged

QR Scanner#412
ifisq merged 16 commits intodevfrom
aryan/qr-scanner

Conversation

@ifisq
Copy link
Copy Markdown
Contributor

@ifisq ifisq commented Jan 14, 2022

Description

Fixes #135

  • Adds QR scanner functionality to app.

Todos

Screenshots

I don't have a screenshot of this working since we don't have any usable QR codes yet. The only added page is a camera for the QR scanner.

Copy link
Copy Markdown
Contributor

@ashayp22 ashayp22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QR Scanner works perfectly, great work Aryan😄!

I left some inline comments, but they should be quick to fix.

After you finish up with closing the QR scanner after scanning a code, I can take a look at any new code and then you can merge ✅

@ifisq
Copy link
Copy Markdown
Contributor Author

ifisq commented Jan 16, 2022

@ashayp22 I've implemented your requested changes. I also updated the branch to the latest version of dev to resolve a merge conflict. Just wanted to let you know that for some reason, the latest version of dev isn't building on my MacBook properly, and I'm getting an error that it isn't able to load one of the assets you added. Here's a screenshot:
image

@ashayp22
Copy link
Copy Markdown
Contributor

ashayp22 commented Jan 16, 2022

@ashayp22 I've implemented your requested changes. I also updated the branch to the latest version of dev to resolve a merge conflict. Just wanted to let you know that for some reason, the latest version of dev isn't building on my MacBook properly, and I'm getting an error that it isn't able to load one of the assets you added. Here's a screenshot: image

@ifisq I deleted the Matching asset since we no longer will be using it. You can replace that line with:
tabBarItem = UITabBarItem(title: "", image: #imageLiteral(resourceName: "leaderboard"), selectedImage: #imageLiteral(resourceName: "LeaderboardSelected"))

ashayp22
ashayp22 previously approved these changes Jan 16, 2022
Copy link
Copy Markdown
Contributor

@ashayp22 ashayp22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tiny change: can you make the color of the closeButton black?

After that, feel free to go ahead and merge!


Update: Sorry, one more thing: I noticed that if the user

  1. Goes to the Profile page
  2. Clicks the QR Scanner button and scans a QR code
  3. Returns back to the Profile page after the QR scanner is closed.

The points aren't updated on the Profile Page.

I think this is because reloadProfile() function in HIProfileViewController isn't called after the QR scanner is closed. Can you think of a way to call that function after the user successfully scans a QR code?

@ifisq
Copy link
Copy Markdown
Contributor Author

ifisq commented Jan 16, 2022

@ashayp22 i've added the requested changes, let me know if there's anything else i need to do before merging.

Copy link
Copy Markdown
Contributor

@ashayp22 ashayp22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can merge

@ifisq ifisq merged commit 3c36b2c into dev Jan 20, 2022
@ifisq ifisq deleted the aryan/qr-scanner branch January 20, 2022 02:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants