This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Merged
Conversation
carters101
requested review from
PatrickKan,
ashayp22 and
jeffkim2001
as code owners
ashayp22
suggested changes
Feb 5, 2022
Contributor
ashayp22
left a comment
ashayp22
left a comment
There was a problem hiding this comment.
Looks great! I left two small inline comments.
|
|
||
| fetchRequest.sortDescriptors = [ | ||
| NSSortDescriptor(key: "id", ascending: true) | ||
| NSSortDescriptor(key: "points", ascending: false) |
Contributor
There was a problem hiding this comment.
Can you add a sort descriptor for the firstName? When multiple people have the same number of points, the leaderboard seems to display people in a different order during every refresh.
NSSortDescriptor(key: "firstName", ascending: true)
| @@ -65,20 +63,7 @@ extension HILeaderboardViewController { | |||
| extension HILeaderboardViewController { | |||
Contributor
There was a problem hiding this comment.
Can you remove the any HIErrorViewDelegate code from HILeaderboardViewController since the Leaderboard View will no longer need it?
ashayp22
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #135
Screenshots