This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Conversation
louisunlimited
requested review from
ashayp22,
jeffkim2001 and
lasyaneti
as code owners
Member
Author
|
The remaining warnings are from dependencies that I have no control over, and I suppose Rahul is not gonna update those ever again. I fixed all the warnings in Lottie by upgrading to their latest release. Had to change a few lines of code for that, but I tested the animations and they seem to work. |
Member
Author
|
Please check my custom warnings for further reference :) |
Member
Author
|
Cleaned up all SwiftLint Violations, (apart from function body length violation) |
lasyaneti
approved these changes
Dec 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed most but not all deprecations for bumping deployment target to iOS 14.
.alertis a bit harder to fix so I let it go at the time of this pr. imo we can leave this till later on and see what to do.I have written custom warnings for all the changes that might potentially require testing.
Todos
All of these changes are not tested because I don't know how. But only some of those require testing I believe.