Conversation
Aymalla
requested review from
julioalex-rezende,
kusweta,
macromania and
ross-p-smith
Aymalla
changed the title
macromania
reviewed
Jun 12, 2023
Collaborator
macromania
left a comment
macromania
left a comment
There was a problem hiding this comment.
Really good work @Aymalla . I have provided some comments and they are not Request changes on purpose.
Because they are just naming comments and doesn't change the implementation, it is up to you if you'd like to accept the commentary or dismiss them 👍🏼
examples/src/main/java/io/dapr/examples/workflows/DemoWorkflowClient.java
Outdated
Show resolved
Hide resolved
sdk-workflows/src/main/java/io/dapr/workflows/client/WorkflowMetadata.java
Outdated
Show resolved
Hide resolved
sdk-workflows/src/main/java/io/dapr/workflows/client/WorkflowRuntimeStatus.java
Outdated
Show resolved
Hide resolved
sdk-workflows/src/main/java/io/dapr/workflows/client/DaprWorkflowClient.java
Outdated
Show resolved
Hide resolved
…rino/java-sdk into aym/getInstanceMetadata
Author
|
@macromania FYI: the new commits is generated from rebasing my branch |
Aymalla
changed the title
macromania
pushed a commit
that referenced
this pull request
Jun 14, 2023
* addiny getInstanceMetadata, waitForInstanceStart and waitForInstanceCompletion implementation --------- Co-authored-by: aymanmahmoud_microsoft <aymanmahmoud@microsoft.com>
macromania
pushed a commit
that referenced
this pull request
Jun 21, 2023
* addiny getInstanceMetadata, waitForInstanceStart and waitForInstanceCompletion implementation --------- Co-authored-by: aymanmahmoud_microsoft <aymanmahmoud@microsoft.com> Signed-off-by: Aymand Mahmoud <aymanmahmoud@microsoft.com> Signed-off-by: Mahmut Canga <cangamahmut@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an implementation and testing for workflow management API >
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: Task 46485-mgmt API- getInstanceMetadata
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: