Skip to content

[algorithm] Refactor algorithm #38

@th-skam

Description

@th-skam

Initial rework/clean-up

After #36, it is time to clean the algorithm a bit. Some issues:

  • Inconsistent descriptions, non-transparent naming choices.
  • Unnecessary copies - use refs when possible.
  • Avoid raw ptrs if possible.
  • Sanity/safety checks in init and doDetection are missing.

Addressed in #47 to #53.

Use of Operation classes in InsertionAlgorithm

  • Use operations for geometric checks to include proximities instead of explicit dynamic casts at the top-level algorithm
  • Use operations to decide based on geometric criteria whether the needle is retracting or not

Metadata

Metadata

Assignees

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions