Implement support of tuple key in __getitem__ and __setitem__#1362
Merged
antonwolfy merged 2 commits intoIntelPython:masterfrom Apr 4, 2023
Merged
Implement support of tuple key in __getitem__ and __setitem__#1362antonwolfy merged 2 commits intoIntelPython:masterfrom
antonwolfy merged 2 commits intoIntelPython:masterfrom
Conversation
oleksandr-pavlyk
approved these changes
Apr 3, 2023
Contributor
|
By the way, using I can not quite put my finger on what property of the container makes NumPy behave like this. I have tried to create a mock indexable array, but it behaves different: |
55c5990 to
5b082f8
Compare
Contributor
Author
There will be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is about to close #1361.
It introduced support of key as a tuple in
dpnp.__getitem__()anddpnp.__setitem__()functions.Previously dpnp was falling back on dpctl call in case of tuple as a key, but it is not always correct.
It requires to unwrap dpnp array into USM ndarray for each dpnp array in tuple key before invoking dpctl functions.