Skip to content

Consolidate SYCL kernels under a single folder#2816

Merged
antonwolfy merged 17 commits intomasterfrom
move-functors-to-kernels-dir
Mar 19, 2026
Merged

Consolidate SYCL kernels under a single folder#2816
antonwolfy merged 17 commits intomasterfrom
move-functors-to-kernels-dir

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 12, 2026

This PR moves all SYCL kernel functors from extensions/ to kernels/ directory, improving the project structure.

Moved kernels:

  • statistics: histogram, sliding_window1d functors
  • indexing: choose functor
  • window: bartlett, blackman, hamming, hanning, kaiser functors

The PR also improves the code coverage report, since the SYCL kernels can be easy excluded from the report now.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy self-assigned this Mar 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Array API standard conformance tests for dpnp=0.20.0dev4=py313h509198e_29 ran successfully.
Passed: 1354
Failed: 3
Skipped: 16

@coveralls
Copy link
Collaborator

coveralls commented Mar 12, 2026

Coverage Status

coverage: 81.962% (+0.6%) from 81.379%
when pulling 1de4186 on move-functors-to-kernels-dir
into 95ab6a0 on master.

@antonwolfy antonwolfy force-pushed the move-functors-to-kernels-dir branch from f483cd0 to 8eac1bf Compare March 17, 2026 11:47
@antonwolfy antonwolfy changed the title Move Functors to dedicated kernels folder Consolidate SYCL kernels under a single folder Mar 17, 2026
@antonwolfy antonwolfy added this to the 0.20.0 release milestone Mar 17, 2026
@antonwolfy antonwolfy marked this pull request as ready for review March 17, 2026 16:09
@antonwolfy antonwolfy force-pushed the move-functors-to-kernels-dir branch from e6a1dec to b7f8f07 Compare March 19, 2026 10:10
@antonwolfy antonwolfy force-pushed the move-functors-to-kernels-dir branch from b3b001a to 1de4186 Compare March 19, 2026 14:19
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit c8c0f88 into master Mar 19, 2026
64 of 69 checks passed
@antonwolfy antonwolfy deleted the move-functors-to-kernels-dir branch March 19, 2026 17:05
github-actions bot added a commit that referenced this pull request Mar 19, 2026
This PR moves all SYCL kernel functors from extensions/ to kernels/
directory, improving the project structure.

Moved kernels:
- statistics: histogram, sliding_window1d functors
- indexing: choose functor
- window: bartlett, blackman, hamming, hanning, kaiser functors

The PR also improves the code coverage report, since the SYCL kernels
can be easy excluded from the report now. c8c0f88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants