Groupby limitations#782
Conversation
| """ | ||
| Limitations | ||
| ----------- | ||
| - This function may reveal slower performance than Pandas* on user system. Users should exercise a tradeoff | ||
| between staying in JIT-region with that function or going back to interpreter mode. | ||
| """, |
There was a problem hiding this comment.
Put this in a separate variable to avoid code duplication
There was a problem hiding this comment.
I do not think it is necessary here
There was a problem hiding this comment.
If we need to add or change limitations, we will have to rewrite the text from the variables back to the lines. To the fact that so clearly
There was a problem hiding this comment.
I vote for inserting the constant text This function may reveal slower performance than Pandas* on user system. Users should exercise a tradeoff between staying in JIT-region with that function or going back to interpreter mode. where it requires through string formatting:
performance_limitation = `This function may reveal slower performance than Pandas* on user system. Users should exercise a tradeoff
between staying in JIT-region with that function or going back to interpreter mode.`
...
'limitations_block':
"""
Limitations
-----------
- {}.
""".format(performance_limitation),
...There was a problem hiding this comment.
or
performance_limitation = `This function may reveal slower performance than Pandas* on user system. Users should exercise a tradeoff
between staying in JIT-region with that function or going back to interpreter mode.`
...
'limitations_block':
f"""
Limitations
-----------
- {performance_limitation}
""",
...
densmirn
left a comment
There was a problem hiding this comment.
Thanks! One more question, could you insert example of generated documentation based on these changes to the PR as a screenshot?

No description provided.