Skip to content

Fix localStorage access throwing in restricted environments (#524)#557

Closed
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-524-mmmYy
Closed

Fix localStorage access throwing in restricted environments (#524)#557
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-524-mmmYy

Conversation

@davidtruong
Copy link
Copy Markdown

Replace all direct localStorage calls with safeLocalStorage wrapper that detects availability and falls back to in-memory storage. This prevents crashes in mobile webviews and iOS Safari private browsing.

https://claude.ai/code/session_01GW85dHHX1Jv15PEoMqdiah

JIRA Ticket(s) if any

Description

Test Steps

Replace all direct localStorage calls with safeLocalStorage wrapper that
detects availability and falls back to in-memory storage. This prevents
crashes in mobile webviews and iOS Safari private browsing.

https://claude.ai/code/session_01GW85dHHX1Jv15PEoMqdiah
@davidtruong davidtruong requested a review from mprew97 as a code owner April 7, 2026 14:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.88372% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.38%. Comparing base (190a168) to head (b618301).

Files with missing lines Patch % Lines
src/utils/localStorage.ts 67.85% 9 Missing ⚠️
src/utils/functions.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   74.45%   74.38%   -0.07%     
==========================================
  Files          57       58       +1     
  Lines        2736     2768      +32     
  Branches      798      825      +27     
==========================================
+ Hits         2037     2059      +22     
+ Misses        698      668      -30     
- Partials        1       41      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtruong
Copy link
Copy Markdown
Author

Things are fixed

@davidtruong davidtruong closed this Apr 8, 2026
@davidtruong davidtruong deleted the claude/fix-issue-524-mmmYy branch April 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants