Remove lodash and uuid dependencies to reduce bundle size#558
Closed
davidtruong wants to merge 1 commit intomainfrom
Closed
Remove lodash and uuid dependencies to reduce bundle size#558davidtruong wants to merge 1 commit intomainfrom
davidtruong wants to merge 1 commit intomainfrom
Conversation
Replace lodash/set with a simple object spread (single usage in inapp.ts) and replace uuid with native crypto.randomUUID() plus a fallback, removing ~73KB of unnecessary dependency weight. Fixes #442. https://claude.ai/code/session_01EkgzU53JWSx3YHoupSiixd
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| delete dataFields[SHARED_PREFS_EVENT_TYPE]; | ||
|
|
||
| const userId = uuidv4(); | ||
| const userId = generateUUID(); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
- Coverage 74.45% 74.36% -0.09%
==========================================
Files 57 58 +1
Lines 2736 2742 +6
Branches 798 817 +19
==========================================
+ Hits 2037 2039 +2
+ Misses 698 662 -36
- Partials 1 41 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Things are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace lodash/set with a simple object spread (single usage in inapp.ts) and replace uuid with native crypto.randomUUID() plus a fallback, removing ~73KB of unnecessary dependency weight. Fixes #442.
https://claude.ai/code/session_01EkgzU53JWSx3YHoupSiixd
JIRA Ticket(s) if any
Description
Test Steps