Fix generateJWT closure capture to use updatable global reference#559
Closed
davidtruong wants to merge 1 commit intomainfrom
Closed
Fix generateJWT closure capture to use updatable global reference#559davidtruong wants to merge 1 commit intomainfrom
davidtruong wants to merge 1 commit intomainfrom
Conversation
The generateJWT callback passed to initialize() was captured in a closure and never updated, causing stale references in React apps where the callback depends on changing state (e.g., rotating user tokens). Changed all internal references from the closure-captured parameter to the module-level generateJWTGlobal variable, and added a setGenerateJWT() method to the WithJWT interface so users can update the function after initialization without reinitializing the entire SDK. Also improved the type of generateJWTGlobal from `any` to a proper type alias (GenerateJWTFunction) for better type safety, and added jest.clearAllTimers() in test beforeEach to fix timer leak between tests. Fixes #160 https://claude.ai/code/session_01TDMxsnQDkRoXn4181Vrv95
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
- Coverage 74.45% 74.44% -0.01%
==========================================
Files 57 57
Lines 2736 2739 +3
Branches 798 815 +17
==========================================
+ Hits 2037 2039 +2
+ Misses 698 659 -39
- Partials 1 41 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Things are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generateJWT callback passed to initialize() was captured in a closure and never updated, causing stale references in React apps where the callback depends on changing state (e.g., rotating user tokens).
Changed all internal references from the closure-captured parameter to the module-level generateJWTGlobal variable, and added a setGenerateJWT() method to the WithJWT interface so users can update the function after initialization without reinitializing the entire SDK.
Also improved the type of generateJWTGlobal from
anyto a proper type alias (GenerateJWTFunction) for better type safety, and added jest.clearAllTimers() in test beforeEach to fix timer leak between tests.Fixes #160
https://claude.ai/code/session_01TDMxsnQDkRoXn4181Vrv95
JIRA Ticket(s) if any
Description
Test Steps