Skip to content

Add allowIframeScripts config to fix Safari in-app message functionality#561

Closed
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-490-F73l1
Closed

Add allowIframeScripts config to fix Safari in-app message functionality#561
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-490-F73l1

Conversation

@davidtruong
Copy link
Copy Markdown

Safari blocks JS execution in sandboxed iframes without allow-scripts, preventing click tracking, action:// links, and proper close button behavior. This adds an opt-in allowIframeScripts config option that adds allow-scripts to the iframe sandbox attribute and disables Safari-specific workarounds, giving Safari users the same full functionality as Chrome/Firefox.

Fixes #490

https://claude.ai/code/session_01Lnv6rRRdYi5TVqPDpjVgvT

JIRA Ticket(s) if any

Description

Test Steps

Safari blocks JS execution in sandboxed iframes without allow-scripts,
preventing click tracking, action:// links, and proper close button behavior.
This adds an opt-in allowIframeScripts config option that adds allow-scripts
to the iframe sandbox attribute and disables Safari-specific workarounds,
giving Safari users the same full functionality as Chrome/Firefox.

Fixes #490

https://claude.ai/code/session_01Lnv6rRRdYi5TVqPDpjVgvT
@davidtruong davidtruong requested a review from mprew97 as a code owner April 7, 2026 14:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.47%. Comparing base (190a168) to head (a5c5eba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   74.45%   74.47%   +0.02%     
==========================================
  Files          57       57              
  Lines        2736     2739       +3     
  Branches      798      817      +19     
==========================================
+ Hits         2037     2040       +3     
+ Misses        698      658      -40     
- Partials        1       41      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtruong
Copy link
Copy Markdown
Author

Things are fixed

@davidtruong davidtruong closed this Apr 8, 2026
@davidtruong davidtruong deleted the claude/fix-issue-490-F73l1 branch April 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inApp clicks Safari

3 participants