fix: move dev-only deps to devDependencies and make customPayload opt…#563
Closed
davidtruong wants to merge 1 commit intomainfrom
Closed
fix: move dev-only deps to devDependencies and make customPayload opt…#563davidtruong wants to merge 1 commit intomainfrom
davidtruong wants to merge 1 commit intomainfrom
Conversation
…ional Move copy-webpack-plugin and axios-mock-adapter from dependencies to devDependencies since they are only used in webpack dev config and test files respectively. This prevents consumers from installing unnecessary packages, including the vulnerable serialize-javascript transitive dep. Also make InAppMessage.customPayload optional to match runtime behavior where the API may return undefined when no custom payload is configured. Fixes #528, Fixes #538 https://claude.ai/code/session_011XYfVrCRu4H8y24ZEpoboX
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=======================================
Coverage 74.45% 74.45%
=======================================
Files 57 57
Lines 2736 2736
Branches 798 815 +17
=======================================
Hits 2037 2037
+ Misses 698 658 -40
- Partials 1 41 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Things are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ional
Move copy-webpack-plugin and axios-mock-adapter from dependencies to devDependencies since they are only used in webpack dev config and test files respectively. This prevents consumers from installing unnecessary packages, including the vulnerable serialize-javascript transitive dep.
Also make InAppMessage.customPayload optional to match runtime behavior where the API may return undefined when no custom payload is configured.
Fixes #528, Fixes #538
https://claude.ai/code/session_011XYfVrCRu4H8y24ZEpoboX
JIRA Ticket(s) if any
Description
Test Steps