Skip to content

fix: move dev-only deps to devDependencies and make customPayload opt…#563

Closed
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-528-D9JYd
Closed

fix: move dev-only deps to devDependencies and make customPayload opt…#563
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-528-D9JYd

Conversation

@davidtruong
Copy link
Copy Markdown

…ional

Move copy-webpack-plugin and axios-mock-adapter from dependencies to devDependencies since they are only used in webpack dev config and test files respectively. This prevents consumers from installing unnecessary packages, including the vulnerable serialize-javascript transitive dep.

Also make InAppMessage.customPayload optional to match runtime behavior where the API may return undefined when no custom payload is configured.

Fixes #528, Fixes #538

https://claude.ai/code/session_011XYfVrCRu4H8y24ZEpoboX

JIRA Ticket(s) if any

Description

Test Steps

…ional

Move copy-webpack-plugin and axios-mock-adapter from dependencies to
devDependencies since they are only used in webpack dev config and test
files respectively. This prevents consumers from installing unnecessary
packages, including the vulnerable serialize-javascript transitive dep.

Also make InAppMessage.customPayload optional to match runtime behavior
where the API may return undefined when no custom payload is configured.

Fixes #528, Fixes #538

https://claude.ai/code/session_011XYfVrCRu4H8y24ZEpoboX
@davidtruong davidtruong requested a review from mprew97 as a code owner April 7, 2026 14:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.45%. Comparing base (190a168) to head (54aaad3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files          57       57           
  Lines        2736     2736           
  Branches      798      815   +17     
=======================================
  Hits         2037     2037           
+ Misses        698      658   -40     
- Partials        1       41   +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtruong
Copy link
Copy Markdown
Author

Things are fixed

@davidtruong davidtruong closed this Apr 8, 2026
@davidtruong davidtruong deleted the claude/fix-issue-528-D9JYd branch April 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InAppMessage.customPayload is not always defined copy-webpack-plugin should be a dev dependency

3 participants