Skip to content

Claude/fix issue 488 gv1fy#564

Closed
davidtruong wants to merge 2 commits intomainfrom
claude/fix-issue-488-GV1fy
Closed

Claude/fix issue 488 gv1fy#564
davidtruong wants to merge 2 commits intomainfrom
claude/fix-issue-488-GV1fy

Conversation

@davidtruong
Copy link
Copy Markdown

JIRA Ticket(s) if any

Description

Test Steps

claude added 2 commits April 7, 2026 14:43
Add a new ESM build target alongside existing UMD builds to enable
modern bundlers (Vite, Rollup, esbuild, webpack 5) to effectively
tree-shake the SDK.

Changes:
- Add webpack.esm.config.js for ES module bundle output
- Add .babelrc.esm.js with modules: false to preserve ES imports/exports
- Add "module" and "exports" fields to package.json for conditional
  module resolution
- Add build:esm script and include it in prepublishOnly

The ESM bundle is published as index.esm.js. Existing UMD builds
(index.js for browser, index.node.js for Node) are unchanged.

Closes #488

https://claude.ai/code/session_015bHPvFJoZHQomDKESZ9tfL
The ESM build output should be ignored like the other build artifacts.

https://claude.ai/code/session_015bHPvFJoZHQomDKESZ9tfL
@davidtruong davidtruong requested a review from mprew97 as a code owner April 7, 2026 14:58
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.45%. Comparing base (190a168) to head (34499c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files          57       57           
  Lines        2736     2736           
  Branches      798      798           
=======================================
  Hits         2037     2037           
  Misses        698      698           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtruong
Copy link
Copy Markdown
Author

Things are fixed

@davidtruong davidtruong closed this Apr 8, 2026
@davidtruong davidtruong deleted the claude/fix-issue-488-GV1fy branch April 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants