Skip to content

Fix trackInApp* payload mutation and add JWT auth test coverage (#552)#567

Closed
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-552-O1I6T
Closed

Fix trackInApp* payload mutation and add JWT auth test coverage (#552)#567
davidtruong wants to merge 1 commit intomainfrom
claude/fix-issue-552-O1I6T

Conversation

@davidtruong
Copy link
Copy Markdown

Replace delete statements with destructuring to avoid mutating the caller's payload object. The interceptor already overwrites email/userId with the correct values from SDK state, so the delete was both unnecessary and harmful as a side effect. Also adds missing JWT auth test coverage for in-app event endpoints.

https://claude.ai/code/session_016eGrVtXnTGForEz4J3Krrm

JIRA Ticket(s) if any

Description

Test Steps

Replace delete statements with destructuring to avoid mutating the
caller's payload object. The interceptor already overwrites email/userId
with the correct values from SDK state, so the delete was both
unnecessary and harmful as a side effect. Also adds missing JWT auth
test coverage for in-app event endpoints.

https://claude.ai/code/session_016eGrVtXnTGForEz4J3Krrm
@davidtruong davidtruong requested a review from mprew97 as a code owner April 7, 2026 15:00
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.40%. Comparing base (190a168) to head (b9da81d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   74.45%   74.40%   -0.05%     
==========================================
  Files          57       57              
  Lines        2736     2731       -5     
  Branches      798      798              
==========================================
- Hits         2037     2032       -5     
  Misses        698      698              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidtruong
Copy link
Copy Markdown
Author

Things are fixed

@davidtruong davidtruong closed this Apr 8, 2026
@davidtruong davidtruong deleted the claude/fix-issue-552-O1I6T branch April 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants