Fix trackInApp* payload mutation and add JWT auth test coverage (#552)#567
Closed
davidtruong wants to merge 1 commit intomainfrom
Closed
Fix trackInApp* payload mutation and add JWT auth test coverage (#552)#567davidtruong wants to merge 1 commit intomainfrom
davidtruong wants to merge 1 commit intomainfrom
Conversation
Replace delete statements with destructuring to avoid mutating the caller's payload object. The interceptor already overwrites email/userId with the correct values from SDK state, so the delete was both unnecessary and harmful as a side effect. Also adds missing JWT auth test coverage for in-app event endpoints. https://claude.ai/code/session_016eGrVtXnTGForEz4J3Krrm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 74.45% 74.40% -0.05%
==========================================
Files 57 57
Lines 2736 2731 -5
Branches 798 798
==========================================
- Hits 2037 2032 -5
Misses 698 698
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Things are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace delete statements with destructuring to avoid mutating the caller's payload object. The interceptor already overwrites email/userId with the correct values from SDK state, so the delete was both unnecessary and harmful as a side effect. Also adds missing JWT auth test coverage for in-app event endpoints.
https://claude.ai/code/session_016eGrVtXnTGForEz4J3Krrm
JIRA Ticket(s) if any
Description
Test Steps